2021-09-13 02:27:56

by Tang Yizhou

Subject: [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to_str

online_policy_to_str is only used in memory_hotplug.c and should be
defined as static.

Signed-off-by: Tang Yizhou <[email protected]>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 0488eed3327c..4ea91c3ff768 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -57,7 +57,7 @@ enum {
ONLINE_POLICY_AUTO_MOVABLE,
};

-const char *online_policy_to_str[] = {
+static const char * const online_policy_to_str[] = {
[ONLINE_POLICY_CONTIG_ZONES] = "contig-zones",
[ONLINE_POLICY_AUTO_MOVABLE] = "auto-movable",
};
--
2.17.1

2021-09-13 03:22:32

by Muchun Song

Subject: Re: [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to_str

On Mon, Sep 13, 2021 at 10:26 AM Tang Yizhou <[email protected]> wrote:
>
> online_policy_to_str is only used in memory_hotplug.c and should be
> defined as static.
>
> Signed-off-by: Tang Yizhou <[email protected]>

LGTM.

Reviewed-by: Muchun Song <[email protected]>

2021-09-13 08:43:22

by David Hildenbrand

Subject: Re: [PATCH] mm/memory_hotplug: Add static qualifier for online_policy_to_str

On 13.09.21 04:45, Tang Yizhou wrote:
> online_policy_to_str is only used in memory_hotplug.c and should be
> defined as static.
>
> Signed-off-by: Tang Yizhou <[email protected]>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 0488eed3327c..4ea91c3ff768 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -57,7 +57,7 @@ enum {
> ONLINE_POLICY_AUTO_MOVABLE,
> };
>
> -const char *online_policy_to_str[] = {
> +static const char * const online_policy_to_str[] = {
> [ONLINE_POLICY_CONTIG_ZONES] = "contig-zones",
> [ONLINE_POLICY_AUTO_MOVABLE] = "auto-movable",
> };
>

Indeed, thanks

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb