2021-09-13 08:38:37

by Paul Menzel

Subject: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware

The warning

amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported

leaves the reader wondering, if anything can be done about it. As it’s
unsupported in the hardware, and nothing can be done about, mention that
in the log message.

amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware

Signed-off-by: Paul Menzel <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index c7797eac83c3..c4c56c57b0c0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
default:
adev->gmc.tmz_enabled = false;
dev_warn(adev->dev,
- "Trusted Memory Zone (TMZ) feature not supported\n");
+ "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
break;
}
}
--
2.33.0

2021-09-13 08:38:37

by Paul Menzel

Subject: [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info

As the user cannot do anything about the unsupported Trusted Memory Zone
(TMZ) feature, do not warn about it, but make it informational, so
demote the log level from warning to info.

Signed-off-by: Paul Menzel <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index c4c56c57b0c0..bfa0275ff5d4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -598,7 +598,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
break;
default:
adev->gmc.tmz_enabled = false;
- dev_warn(adev->dev,
+ dev_info(adev->dev,
"Trusted Memory Zone (TMZ) feature not supported by hardware\n");
break;
}
--
2.33.0

2021-09-13 08:43:28

by Christian König

Subject: Re: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware

Am 13.09.21 um 10:34 schrieb Paul Menzel:
> The warning
>
> amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
>
> leaves the reader wondering, if anything can be done about it. As it’s
> unsupported in the hardware, and nothing can be done about, mention that
> in the log message.
>
> amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware

I think we should just completely remove the message instead.

Christian.

>
> Signed-off-by: Paul Menzel <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c7797eac83c3..c4c56c57b0c0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
> default:
> adev->gmc.tmz_enabled = false;
> dev_warn(adev->dev,
> - "Trusted Memory Zone (TMZ) feature not supported\n");
> + "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
> break;
> }
> }

2021-09-14 00:44:59

by Alex Deucher

Subject: Re: [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info

Applied. Thanks.

Alex

On Mon, Sep 13, 2021 at 4:46 AM Paul Menzel <[email protected]> wrote:
>
> As the user cannot do anything about the unsupported Trusted Memory Zone
> (TMZ) feature, do not warn about it, but make it informational, so
> demote the log level from warning to info.
>
> Signed-off-by: Paul Menzel <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c4c56c57b0c0..bfa0275ff5d4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -598,7 +598,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
> break;
> default:
> adev->gmc.tmz_enabled = false;
> - dev_warn(adev->dev,
> + dev_info(adev->dev,
> "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
> break;
> }
> --
> 2.33.0
>