2021-09-14 06:05:18

by Fei Li

[permalink] [raw]
Subject: [RFC PATCH v3 0/2] Introduce some interfaces for ACRN hypervisor HSM driver

Add some new interfaces for ACRN hypervisor HSM driver:
- MMIO device passthrough
- virtual device creating/destroying
- platform information fetching from the hypervisor

ChangeLog:
v3:
- remove "platform information fetching from the hypervisor". What platform
information needs to be fetched has not been finally decided. Will send tis
patch out once that has been decided.
- add comments where is the userspace code that uses this new api:
- MMIO device passthrough
(a) assign a MMIO device to a User VM
https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L562
(b) de-assign a MMIO device from a User VM
https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L568
- virtual device creating/destroying
(a) create a virtual device for a User VM
https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L606
(b) destroy a virtual device of a User VM
https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/core/vmmapi.c#L612

v2:
- remove "[email protected]" in the cc list since this patch set
doesn't fix any anything, it's not for Linux -stable releases.

Shuo Liu (2):
virt: acrn: Introduce interfaces for MMIO device passthrough
virt: acrn: Introduce interfaces for virtual device
creating/destroying

drivers/virt/acrn/hsm.c | 49 ++++++++++++++++++++++++
drivers/virt/acrn/hypercall.h | 52 ++++++++++++++++++++++++++
include/uapi/linux/acrn.h | 70 +++++++++++++++++++++++++++++++++++
3 files changed, 171 insertions(+)


base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
--
2.17.1


2021-09-14 06:10:24

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [RFC PATCH v3 0/2] Introduce some interfaces for ACRN hypervisor HSM driver

On Tue, Sep 14, 2021 at 02:01:39PM +0800, Fei Li wrote:
> Add some new interfaces for ACRN hypervisor HSM driver:
> - MMIO device passthrough
> - virtual device creating/destroying
> - platform information fetching from the hypervisor

"RFC" means that you do not feel good about having these merged. What
needs to be finished before you send a "real" set of patches that you
want to have reviewed properly?

thanks,

greg k-h

2021-09-14 06:16:07

by Fei Li

[permalink] [raw]
Subject: Re: [RFC PATCH v3 0/2] Introduce some interfaces for ACRN hypervisor HSM driver

On Tue, Sep 14, 2021 at 08:07:01AM +0200, Greg KH wrote:
> On Tue, Sep 14, 2021 at 02:01:39PM +0800, Fei Li wrote:
> > Add some new interfaces for ACRN hypervisor HSM driver:
> > - MMIO device passthrough
> > - virtual device creating/destroying
> > - platform information fetching from the hypervisor
>
> "RFC" means that you do not feel good about having these merged. What
> needs to be finished before you send a "real" set of patches that you
> want to have reviewed properly?

Hi Greg

Sorry, please ignore the "RFC".
I feel good about these patches. Would you help to review these patches ?

thanks.

>
> thanks,
>
> greg k-h

2021-09-14 06:21:08

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [RFC PATCH v3 0/2] Introduce some interfaces for ACRN hypervisor HSM driver

On Tue, Sep 14, 2021 at 02:14:19PM +0800, Li Fei1 wrote:
> On Tue, Sep 14, 2021 at 08:07:01AM +0200, Greg KH wrote:
> > On Tue, Sep 14, 2021 at 02:01:39PM +0800, Fei Li wrote:
> > > Add some new interfaces for ACRN hypervisor HSM driver:
> > > - MMIO device passthrough
> > > - virtual device creating/destroying
> > > - platform information fetching from the hypervisor
> >
> > "RFC" means that you do not feel good about having these merged. What
> > needs to be finished before you send a "real" set of patches that you
> > want to have reviewed properly?
>
> Hi Greg
>
> Sorry, please ignore the "RFC".
> I feel good about these patches. Would you help to review these patches ?

They are gone from my queue, please resend without the "RFC".

thanks,

greg k-h

2021-09-14 06:23:23

by Fei Li

[permalink] [raw]
Subject: Re: [RFC PATCH v3 0/2] Introduce some interfaces for ACRN hypervisor HSM driver

On Tue, Sep 14, 2021 at 08:19:21AM +0200, Greg KH wrote:
> On Tue, Sep 14, 2021 at 02:14:19PM +0800, Li Fei1 wrote:
> > On Tue, Sep 14, 2021 at 08:07:01AM +0200, Greg KH wrote:
> > > On Tue, Sep 14, 2021 at 02:01:39PM +0800, Fei Li wrote:
> > > > Add some new interfaces for ACRN hypervisor HSM driver:
> > > > - MMIO device passthrough
> > > > - virtual device creating/destroying
> > > > - platform information fetching from the hypervisor
> > >
> > > "RFC" means that you do not feel good about having these merged. What
> > > needs to be finished before you send a "real" set of patches that you
> > > want to have reviewed properly?
> >
> > Hi Greg
> >
> > Sorry, please ignore the "RFC".
> > I feel good about these patches. Would you help to review these patches ?
>
> They are gone from my queue, please resend without the "RFC".
OK.
thanks.

>
> thanks,
>
> greg k-h