2021-09-16 10:52:44

by Xiang wangx

Subject: [PATCH] selftests: nci: fix grammatical errors

Should not use unsigned expression compared with zero

Signed-off-by: Xiang wangx <[email protected]>
---
tools/testing/selftests/nci/nci_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index e1bf55dabdf6..162c41e9bcae 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
const __u8 *rsp, __u32 rsp_len)
{
char buf[256];
- unsigned int len;
+ int len;

send(nfc_sock, &cmd[3], cmd_len - 3, 0);
len = read(virtual_fd, buf, cmd_len);
--
2.20.1

2021-09-16 11:24:08

by Bongsu Jeon

Subject: Re: [PATCH] selftests: nci: fix grammatical errors

Actually I asked to fix grammatical errors in the subject.
For example => selftests: nci: replace unsigned int with int

And please change the log in more detail and put a period at the end
of the log.
For example => Should not use comparison of unsigned expressions < 0.

In addition to that, please send patch version 2 with changelog.
For example=> [PATCH v2 net] ~~~~.


On Thu, Sep 16, 2021 at 7:53 PM Xiang wangx <[email protected]> wrote:
>
> Should not use unsigned expression compared with zero
>
> Signed-off-by: Xiang wangx <[email protected]>
> ---
> tools/testing/selftests/nci/nci_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
> index e1bf55dabdf6..162c41e9bcae 100644
> --- a/tools/testing/selftests/nci/nci_dev.c
> +++ b/tools/testing/selftests/nci/nci_dev.c
> @@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
> const __u8 *rsp, __u32 rsp_len)
> {
> char buf[256];
> - unsigned int len;
> + int len;
>
> send(nfc_sock, &cmd[3], cmd_len - 3, 0);
> len = read(virtual_fd, buf, cmd_len);
> --
> 2.20.1
>