2021-09-17 14:12:22

by Michal Kubecek

Subject: [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM

Function nintendo_otp_probe() calls devm_ioremap_resource() which is only
available if CONFIG_HAS_IOMEM is enabled. Add a kconfig dependency like
other similar drivers have.

Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
Signed-off-by: Michal Kubecek <[email protected]>
---
drivers/nvmem/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 39854d43758b..fb4005df86c0 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -108,6 +108,7 @@ config MTK_EFUSE
will be called efuse-mtk.

config NVMEM_NINTENDO_OTP
+ depends on HAS_IOMEM
tristate "Nintendo Wii and Wii U OTP Support"
help
This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
--
2.33.0

2021-09-17 14:14:17

by Michal Kubecek

Subject: Re: [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM

On Fri, Sep 17, 2021 at 01:20:18PM +0200, Michal Kubecek wrote:
> Function nintendo_otp_probe() calls devm_ioremap_resource() which is only
> available if CONFIG_HAS_IOMEM is enabled. Add a kconfig dependency like
> other similar drivers have.
>
> Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Michal Kubecek <[email protected]>

A note: the build failure was already reported in

https://lore.kernel.org/all/[email protected]/

Michal

> ---
> drivers/nvmem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758b..fb4005df86c0 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -108,6 +108,7 @@ config MTK_EFUSE
> will be called efuse-mtk.
>
> config NVMEM_NINTENDO_OTP
> + depends on HAS_IOMEM
> tristate "Nintendo Wii and Wii U OTP Support"
> help
> This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
> --
> 2.33.0
>