2021-09-28 17:52:32

by Mianhan Liu

Subject: [PATCH -next] net/ipv4/datagram.c: remove superfluous header files from datagram.c

datagram.c hasn't use any macro or function declared in linux/ip.h,
and linux/module.h.
Thus, these files can be removed from datagram.c safely without
affecting the compilation of the net/ipv4 module

Signed-off-by: Mianhan Liu <[email protected]>

---
net/ipv4/datagram.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c
index 4a8550c49..2dc5f1890 100644
--- a/net/ipv4/datagram.c
+++ b/net/ipv4/datagram.c
@@ -8,8 +8,6 @@
*/

#include <linux/types.h>
-#include <linux/module.h>
-#include <linux/ip.h>
#include <linux/in.h>
#include <net/ip.h>
#include <net/sock.h>
--
2.25.1

2021-09-29 00:43:28

by Jakub Kicinski

Subject: Re: [PATCH -next] net/ipv4/datagram.c: remove superfluous header files from datagram.c

On Wed, 29 Sep 2021 01:49:43 +0800 Mianhan Liu wrote:
> datagram.c hasn't use any macro or function declared in linux/ip.h,
> and linux/module.h.
> Thus, these files can be removed from datagram.c safely without
> affecting the compilation of the net/ipv4 module
>
> Signed-off-by: Mianhan Liu <[email protected]>
>
> ---
> net/ipv4/datagram.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c
> index 4a8550c49..2dc5f1890 100644
> --- a/net/ipv4/datagram.c
> +++ b/net/ipv4/datagram.c
> @@ -8,8 +8,6 @@
> */
>
> #include <linux/types.h>
> -#include <linux/module.h>

If we remove this one we need to add an include for linux/export.h

> -#include <linux/ip.h>

This indeed looks unnecessary.

> #include <linux/in.h>
> #include <net/ip.h>
> #include <net/sock.h>