2021-09-29 20:36:43

by Dawid Esterhuizen

Subject: [PATCH] staging: rtl8712: Statements should start on a tabstop

This path fixes four checkpatch.pl warnings:

Statements should start on a tabstop

Signed-off-by: Dawid Esterhuizen <[email protected]>
---
drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
index 2e6afc7bb0a1..bc1287cc853e 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.h
+++ b/drivers/staging/rtl8712/rtl871x_xmit.h
@@ -182,11 +182,11 @@ struct sta_xmit_priv {
};

struct hw_txqueue {
- /*volatile*/ sint head;
- /*volatile*/ sint tail;
- /*volatile*/ sint free_sz; /*in units of 64 bytes*/
- /*volatile*/ sint free_cmdsz;
- /*volatile*/ sint txsz[8];
+ /*volatile*/ sint head;
+ /*volatile*/ sint tail;
+ /*volatile*/ sint free_sz; /*in units of 64 bytes*/
+ /*volatile*/ sint free_cmdsz;
+ /*volatile*/ sint txsz[8];
uint ff_hwaddr;
uint cmd_hwaddr;
sint ac_tag;
--
2.33.0

2021-09-29 23:50:53

by Bryan Brattlof

Subject: Re: [PATCH] staging: rtl8712: Statements should start on a tabstop

Welcome Dawid!

On this day, September 29, 2021, thus sayeth Dawid Esterhuizen:
> This path fixes four checkpatch.pl warnings:
>
> Statements should start on a tabstop
>
> Signed-off-by: Dawid Esterhuizen <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
> };
>
> struct hw_txqueue {
> - /*volatile*/ sint head;
> - /*volatile*/ sint tail;
> - /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> - /*volatile*/ sint free_cmdsz;
> - /*volatile*/ sint txsz[8];
> + /*volatile*/ sint head;
> + /*volatile*/ sint tail;
> + /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> + /*volatile*/ sint free_cmdsz;
> + /*volatile*/ sint txsz[8];
>

I'm thinking a better way to silence checkpatch.pl here would be to
remove the volatile comments. I find it easier to read when everything
is aligned, comment or not.

~Bryan

2021-09-30 06:30:11

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8712: Statements should start on a tabstop

On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
>
> Statements should start on a tabstop
>
> Signed-off-by: Dawid Esterhuizen <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
> };
>
> struct hw_txqueue {
> - /*volatile*/ sint head;
> - /*volatile*/ sint tail;
> - /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> - /*volatile*/ sint free_cmdsz;
> - /*volatile*/ sint txsz[8];
> + /*volatile*/ sint head;
> + /*volatile*/ sint tail;
> + /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> + /*volatile*/ sint free_cmdsz;
> + /*volatile*/ sint txsz[8];

I think you now have added a new checkpatch warning, right?

This is not the correct indentation anymore, why not work to see if you
can remove the volatile comment instead?

thanks,

greg k-h

2021-09-30 06:31:41

by Joe Perches

Subject: Re: [PATCH] staging: rtl8712: Statements should start on a tabstop

On Thu, 2021-09-30 at 08:00 +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> > This path fixes four checkpatch.pl warnings:
> >
> > Statements should start on a tabstop
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
[]
> > @@ -182,11 +182,11 @@ struct sta_xmit_priv {
> > ?};
> > ?
> >
> > ?struct hw_txqueue {
> > - /*volatile*/ sint head;
> > - /*volatile*/ sint tail;
> > - /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> > - /*volatile*/ sint free_cmdsz;
> > - /*volatile*/ sint txsz[8];
> > + /*volatile*/ sint head;
> > + /*volatile*/ sint tail;
> > + /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> > + /*volatile*/ sint free_cmdsz;
> > + /*volatile*/ sint txsz[8];
>
> I think you now have added a new checkpatch warning, right?
>
> This is not the correct indentation anymore, why not work to see if you
> can remove the volatile comment instead?

And maybe one day do

$ sed -i -e 's/\bsint\b/int/' drivers/staging/rtl8712/*.[ch]
$ sed -i 19d drivers/staging/rtl8712/basic_types.h

2021-09-30 09:28:39

by Dan Carpenter

Subject: Re: [PATCH] staging: rtl8712: Statements should start on a tabstop

On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
>
> Statements should start on a tabstop
>
> Signed-off-by: Dawid Esterhuizen <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
> };
>
> struct hw_txqueue {
> - /*volatile*/ sint head;
> - /*volatile*/ sint tail;
> - /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> - /*volatile*/ sint free_cmdsz;
> - /*volatile*/ sint txsz[8];
> + /*volatile*/ sint head;
> + /*volatile*/ sint tail;
> + /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> + /*volatile*/ sint free_cmdsz;
> + /*volatile*/ sint txsz[8];

These "volatile" comments are wrong and pointless. Just delete them
instead.

regards,
dan carpenter