2021-10-11 16:26:45

by Colin King

Subject: [PATCH][next] coredump: Remove redundant initialization of variable core_waiters

From: Colin Ian King <[email protected]>

The variable core_waiters is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and can
be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
fs/coredump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index a6b3c196cdef..2f79f8f7bd56 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -390,7 +390,7 @@ static int zap_threads(struct task_struct *tsk,
static int coredump_wait(int exit_code, struct core_state *core_state)
{
struct task_struct *tsk = current;
- int core_waiters = -EBUSY;
+ int core_waiters;

init_completion(&core_state->startup);
core_state->dumper.task = tsk;
--
2.32.0

2021-10-12 10:41:06

by Christian Brauner

Subject: Re: [PATCH][next] coredump: Remove redundant initialization of variable core_waiters

On Mon, Oct 11, 2021 at 02:16:35PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable core_waiters is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and can
> be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Thanks!
Acked-by: Christian Brauner <[email protected]>