2021-10-12 12:11:16

by Gal Pressman

[permalink] [raw]
Subject: [PATCH for-next 1/3] dma-buf: Fix pin callback comment

The pin callback does not necessarily have to move the memory to system
memory, remove the sentence from the comment.

Signed-off-by: Gal Pressman <[email protected]>
---
include/linux/dma-buf.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index efdc56b9d95f..225e09caeb98 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -86,8 +86,8 @@ struct dma_buf_ops {
* @pin:
*
* This is called by dma_buf_pin() and lets the exporter know that the
- * DMA-buf can't be moved any more. The exporter should pin the buffer
- * into system memory to make sure it is generally accessible by other
+ * DMA-buf can't be moved any more. Ideally, the exporter should
+ * pin the buffer so that it is generally accessible by all
* devices.
*
* This is called with the &dmabuf.resv object locked and is mutual
--
2.33.0


2021-10-18 13:02:36

by Christian König

[permalink] [raw]
Subject: Re: [PATCH for-next 1/3] dma-buf: Fix pin callback comment

Am 12.10.21 um 14:09 schrieb Gal Pressman:
> The pin callback does not necessarily have to move the memory to system
> memory, remove the sentence from the comment.
>
> Signed-off-by: Gal Pressman <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> include/linux/dma-buf.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
> index efdc56b9d95f..225e09caeb98 100644
> --- a/include/linux/dma-buf.h
> +++ b/include/linux/dma-buf.h
> @@ -86,8 +86,8 @@ struct dma_buf_ops {
> * @pin:
> *
> * This is called by dma_buf_pin() and lets the exporter know that the
> - * DMA-buf can't be moved any more. The exporter should pin the buffer
> - * into system memory to make sure it is generally accessible by other
> + * DMA-buf can't be moved any more. Ideally, the exporter should
> + * pin the buffer so that it is generally accessible by all
> * devices.
> *
> * This is called with the &dmabuf.resv object locked and is mutual