2021-10-14 09:00:39

by Jiabing Wan

Subject: [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break

Fix following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function
for_each_matching_node should have of_node_put() before break

Early exits from for_each_matching_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
arch/arm/mach-omap2/omap_hwmod.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index ccb0e3732c0d..31d1a21f6041 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -752,8 +752,10 @@ static int __init _init_clkctrl_providers(void)

for_each_matching_node(np, ti_clkctrl_match_table) {
ret = _setup_clkctrl_provider(np);
- if (ret)
+ if (ret) {
+ of_node_put(np);
break;
+ }
}

return ret;
--
2.20.1

2021-12-17 12:14:21

by Tony Lindgren

Subject: Re: [PATCH] ARM: OMAP2+: hwmod: Add of_node_put() before break

* Wan Jiabing <[email protected]> [211014 11:58]:
> Fix following coccicheck warning:
> ./arch/arm/mach-omap2/omap_hwmod.c:753:1-23: WARNING: Function
> for_each_matching_node should have of_node_put() before break
>
> Early exits from for_each_matching_node should decrement the
> node reference counter.

Thanks adding into omap-for-v5.17/fixes-not-urgent.

Tony