2021-10-15 13:55:14

by Jiabing Wan

Subject: [PATCH] phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2

Fix following coccicheck warning:
./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before break

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
index 34a6a9a1ceb2..b133ae06757a 100644
--- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
+++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
@@ -140,14 +140,19 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)
struct phy *phy;

rst = of_reset_control_get_exclusive(child, NULL);
- if (IS_ERR(rst))
+ if (IS_ERR(rst)) {
+ of_node_put(child);
return PTR_ERR(rst);
+ }
+
priv->ports[i].utmi_rst = rst;
priv->ports[i].priv = priv;

phy = devm_phy_create(dev, child, &hisi_inno_phy_ops);
- if (IS_ERR(phy))
+ if (IS_ERR(phy)) {
+ of_node_put(child);
return PTR_ERR(phy);
+ }

phy_set_bus_width(phy, 8);
phy_set_drvdata(phy, &priv->ports[i]);
@@ -155,6 +160,7 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)

if (i > INNO_PHY_PORT_NUM) {
dev_warn(dev, "Support %d ports in maximum\n", i);
+ of_node_put(child);
break;
}
}
--
2.20.1

2021-10-24 17:17:40

by Vinod Koul

Subject: Re: [PATCH] phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2

On 15-10-21, 04:01, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before break
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.

Applied, thanks

--
~Vinod