2021-10-15 16:28:28

by Rasmus Villemoes

Subject: [PATCH] tools: compiler.h: remove duplicate #ifndef noinline block

The same three lines also appear a bit earlier in the same file.

Signed-off-by: Rasmus Villemoes <[email protected]>
---
tools/include/linux/compiler.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/tools/include/linux/compiler.h b/tools/include/linux/compiler.h
index ff872dc2637c..90ba44a99199 100644
--- a/tools/include/linux/compiler.h
+++ b/tools/include/linux/compiler.h
@@ -102,10 +102,6 @@
# define __init
#endif

-#ifndef noinline
-# define noinline
-#endif
-
#include <linux/types.h>

/*
--
2.31.1

2021-10-15 21:32:46

by Miguel Ojeda

Subject: Re: [PATCH] tools: compiler.h: remove duplicate #ifndef noinline block

On Fri, Oct 15, 2021 at 10:31 AM Rasmus Villemoes
<[email protected]> wrote:
>
> The same three lines also appear a bit earlier in the same file.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Looks good to me -- they also appear to be at the same level.

Reviewed-by: Miguel Ojeda <[email protected]>

Cheers,
Miguel

2022-03-08 14:07:04

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] tools: compiler.h: remove duplicate #ifndef noinline block

Em Fri, Oct 15, 2021 at 01:46:02PM +0200, Miguel Ojeda escreveu:
> On Fri, Oct 15, 2021 at 10:31 AM Rasmus Villemoes
> <[email protected]> wrote:
> >
> > The same three lines also appear a bit earlier in the same file.
> >
> > Signed-off-by: Rasmus Villemoes <[email protected]>
>
> Looks good to me -- they also appear to be at the same level.
>
> Reviewed-by: Miguel Ojeda <[email protected]>

Fell thru the cracks, duh.

Thanks, applied.

- Arnaldo