2021-10-15 23:02:18

by Colin King

Subject: [PATCH] dmaengine: Remove redundant initialization of variable err

From: Colin Ian King <[email protected]>

The variable err is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed
and move the declaration into the local scope.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/dma/dmaengine.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index af3ee288bc11..d9f7c097cfd6 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -695,13 +695,12 @@ static struct dma_chan *find_candidate(struct dma_device *device,
*/
struct dma_chan *dma_get_slave_channel(struct dma_chan *chan)
{
- int err = -EBUSY;
-
/* lock against __dma_request_channel */
mutex_lock(&dma_list_mutex);

if (chan->client_count == 0) {
struct dma_device *device = chan->device;
+ int err;

dma_cap_set(DMA_PRIVATE, device->cap_mask);
device->privatecnt++;
--
2.32.0

2021-10-18 04:31:53

by Vinod Koul

Subject: Re: [PATCH] dmaengine: Remove redundant initialization of variable err

On 15-10-21, 13:34, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed
> and move the declaration into the local scope.

Applied, thanks

--
~Vinod