This allows the driver to call an optional reset driver.
v3->v4:
- use devm_reset_control_get_optional_shared
- remove the expected name of the reset line
v2->v3:
- fix warnings reported by 'make dtbs_check'
v1->v2:
- add dt-bindings changes
Horatiu Vultur (2):
dt-bindings: pinctrl: pinctrl-microchip-sgpio: Add reset binding
pinctrl: microchip sgpio: use reset driver
.../devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml | 3 +++
drivers/pinctrl/pinctrl-microchip-sgpio.c | 5 +++++
2 files changed, 8 insertions(+)
--
2.33.0
This describes the new binding which allows to call a reset driver from
the pinctrl-microchip-sgpio driver.
Signed-off-by: Horatiu Vultur <[email protected]>
---
.../devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
index 4fe35e650909..b0b7d02a57e0 100644
--- a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
@@ -68,6 +68,9 @@ properties:
clock, and larger than zero.
default: 12500000
+ resets:
+ maxItems: 1
+
patternProperties:
"^gpio@[0-1]$":
type: object
--
2.33.0
On lan966x platform when the switch gets reseted then also the sgpio
gets reseted. The fix for this is to extend also the sgpio driver to
call the reset driver which will be reseted only once by the first
driver that is probed.
Signed-off-by: Horatiu Vultur <[email protected]>
---
drivers/pinctrl/pinctrl-microchip-sgpio.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
index 072bccdea2a5..23f5a744edc4 100644
--- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
+++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
@@ -17,6 +17,7 @@
#include <linux/pinctrl/pinmux.h>
#include <linux/platform_device.h>
#include <linux/property.h>
+#include <linux/reset.h>
#include "core.h"
#include "pinconf.h"
@@ -803,6 +804,7 @@ static int microchip_sgpio_probe(struct platform_device *pdev)
int div_clock = 0, ret, port, i, nbanks;
struct device *dev = &pdev->dev;
struct fwnode_handle *fwnode;
+ struct reset_control *reset;
struct sgpio_priv *priv;
struct clk *clk;
u32 val;
@@ -813,6 +815,9 @@ static int microchip_sgpio_probe(struct platform_device *pdev)
priv->dev = dev;
+ reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
+ reset_control_reset(reset);
+
clk = devm_clk_get(dev, NULL);
if (IS_ERR(clk))
return dev_err_probe(dev, PTR_ERR(clk), "Failed to get clock\n");
--
2.33.0
On Fri, 2021-10-15 at 15:25 +0200, Horatiu Vultur wrote:
> On lan966x platform when the switch gets reseted then also the sgpio
> gets reseted. The fix for this is to extend also the sgpio driver to
> call the reset driver which will be reseted only once by the first
> driver that is probed.
>
> Signed-off-by: Horatiu Vultur <[email protected]>
> ---
> drivers/pinctrl/pinctrl-microchip-sgpio.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c
> index 072bccdea2a5..23f5a744edc4 100644
> --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c
> +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c
> @@ -17,6 +17,7 @@
> #include <linux/pinctrl/pinmux.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
> +#include <linux/reset.h>
>
> #include "core.h"
> #include "pinconf.h"
> @@ -803,6 +804,7 @@ static int microchip_sgpio_probe(struct platform_device *pdev)
> int div_clock = 0, ret, port, i, nbanks;
> struct device *dev = &pdev->dev;
> struct fwnode_handle *fwnode;
> + struct reset_control *reset;
> struct sgpio_priv *priv;
> struct clk *clk;
> u32 val;
> @@ -813,6 +815,9 @@ static int microchip_sgpio_probe(struct platform_device *pdev)
>
> priv->dev = dev;
>
> + reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
if (IS_ERR(reset))
return dev_err_probe(dev, PTR_ERR(reset), "Failed to get reset\n");
This could still happen if the device tree is broken or on
-EPROBE_DEFER.
> + reset_control_reset(reset);
> +
> clk = devm_clk_get(dev, NULL);
> if (IS_ERR(clk))
> return dev_err_probe(dev, PTR_ERR(clk), "Failed to get clock\n");
regards
Philipp