2021-10-15 14:05:19

by Jiabing Wan

Subject: [PATCH] PCI: apple: Add of_node_put() before return

Fix following coccicheck warning:
./drivers/pci/controller/pcie-apple.c:771:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/pci/controller/pcie-apple.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index b4db7a065553..13101389e988 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -772,6 +772,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
ret = apple_pcie_setup_port(pcie, of_port);
if (ret) {
dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret);
+ of_node_put(of_port);
return ret;
}
}
--
2.20.1

2021-10-18 11:10:34

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: apple: Add of_node_put() before return

On Fri, Oct 15, 2021 at 04:09:20AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/pci/controller/pcie-apple.c:771:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before return
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/pci/controller/pcie-apple.c | 1 +
> 1 file changed, 1 insertion(+)

Squashed in the commit it is fixing, updated my pci/apple branch.

Thanks,
Lorenzo

>
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index b4db7a065553..13101389e988 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -772,6 +772,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
> ret = apple_pcie_setup_port(pcie, of_port);
> if (ret) {
> dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret);
> + of_node_put(of_port);
> return ret;
> }
> }
> --
> 2.20.1
>