2021-10-15 13:05:37

by Jiabing Wan

Subject: [PATCH] soc: bcm: brcmstb: Add of_node_put() in pm-mips

Fix following coccicheck warning:
./drivers/soc/bcm/brcmstb/pm/pm-mips.c:404:1-23: WARNING: Function
for_each_matching_node should have of_node_put() before goto or break

Early exits from for_each_matching_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/soc/bcm/brcmstb/pm/pm-mips.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/bcm/brcmstb/pm/pm-mips.c b/drivers/soc/bcm/brcmstb/pm/pm-mips.c
index cdc3e387f049..4dfb5a85032b 100644
--- a/drivers/soc/bcm/brcmstb/pm/pm-mips.c
+++ b/drivers/soc/bcm/brcmstb/pm/pm-mips.c
@@ -405,11 +405,14 @@ static int brcmstb_pm_init(void)
i = ctrl.num_memc;
if (i >= MAX_NUM_MEMC) {
pr_warn("Too many MEMCs (max %d)\n", MAX_NUM_MEMC);
+ of_node_put(dn);
break;
}
base = brcmstb_ioremap_node(dn, 0);
- if (IS_ERR(base))
+ if (IS_ERR(base)) {
+ of_node_put(dn);
goto ddr_err;
+ }

ctrl.memcs[i].ddr_phy_base = base;
ctrl.num_memc++;
--
2.20.1

2021-10-20 23:00:50

by Florian Fainelli

Subject: Re: [PATCH] soc: bcm: brcmstb: Add of_node_put() in pm-mips

On Fri, 15 Oct 2021 02:49:23 -0400, Wan Jiabing <[email protected]> wrote:
> Fix following coccicheck warning:
> ./drivers/soc/bcm/brcmstb/pm/pm-mips.c:404:1-23: WARNING: Function
> for_each_matching_node should have of_node_put() before goto or break
>
> Early exits from for_each_matching_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian