the helper macro kthread_run_on_cpu() inculdes
kthread_create_on_cpu/wake_up_process().
In some cases, use kthread_run_on_cpu() directly instead of
kthread_create_on_node/kthread_bind/wake_up_process() or
kthread_create_on_cpu/wake_up_process() or
kthreadd_create/kthread_bind/wake_up_process() to simplify the code.
Cai Huoqing (6):
kthread: Add the helper macro kthread_run_on_cpu()
RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
ring-buffer: Make use of the helper macro kthread_run_on_cpu()
rcutorture: Make use of the helper macro kthread_run_on_cpu()
trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
drivers/infiniband/sw/siw/siw_main.c | 7 +++----
include/linux/kthread.h | 22 ++++++++++++++++++++++
kernel/rcu/rcutorture.c | 7 ++-----
kernel/trace/ring_buffer.c | 7 ++-----
kernel/trace/trace_hwlat.c | 6 +-----
kernel/trace/trace_osnoise.c | 3 +--
6 files changed, 31 insertions(+), 21 deletions(-)
--
2.25.1
Repalce kthread_create_on_node//kthread_bind/wake_up_process()
with kthread_run_on_cpu() to simplify the code.
Signed-off-by: Cai Huoqing <[email protected]>
---
kernel/rcu/rcutorture.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 503e14e62e8f..6c3ba8c0d7ff 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -2025,9 +2025,8 @@ static int rcutorture_booster_init(unsigned int cpu)
mutex_lock(&boost_mutex);
rcu_torture_disable_rt_throttle();
VERBOSE_TOROUT_STRING("Creating rcu_torture_boost task");
- boost_tasks[cpu] = kthread_create_on_node(rcu_torture_boost, NULL,
- cpu_to_node(cpu),
- "rcu_torture_boost");
+ boost_tasks[cpu] = kthread_run_on_cpu(rcu_torture_boost, NULL,
+ cpu, "rcu_torture_boost_%u");
if (IS_ERR(boost_tasks[cpu])) {
retval = PTR_ERR(boost_tasks[cpu]);
VERBOSE_TOROUT_STRING("rcu_torture_boost task create failed");
@@ -2036,8 +2035,6 @@ static int rcutorture_booster_init(unsigned int cpu)
mutex_unlock(&boost_mutex);
return retval;
}
- kthread_bind(boost_tasks[cpu], cpu);
- wake_up_process(boost_tasks[cpu]);
mutex_unlock(&boost_mutex);
return 0;
}
--
2.25.1
Repalce kthread_create/kthread_bind/wake_up_process()
with kthread_run_on_cpu() to simplify the code.
Signed-off-by: Cai Huoqing <[email protected]>
---
kernel/trace/trace_osnoise.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
index ce053619f289..cbd78fd5e491 100644
--- a/kernel/trace/trace_osnoise.c
+++ b/kernel/trace/trace_osnoise.c
@@ -1525,7 +1525,7 @@ static int start_kthread(unsigned int cpu)
#else
snprintf(comm, 24, "osnoise/%d", cpu);
#endif
- kthread = kthread_create_on_cpu(main, NULL, cpu, comm);
+ kthread = kthread_run_on_cpu(main, NULL, cpu, comm);
if (IS_ERR(kthread)) {
pr_err(BANNER "could not start sampling thread\n");
@@ -1534,7 +1534,6 @@ static int start_kthread(unsigned int cpu)
}
per_cpu(per_cpu_osnoise_var, cpu).kthread = kthread;
- wake_up_process(kthread);
return 0;
}
--
2.25.1
Repalce kthread_create/kthread_bind/wake_up_process()
with kthread_run_on_cpu() to simplify the code.
Signed-off-by: Cai Huoqing <[email protected]>
---
kernel/trace/trace_hwlat.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c
index 1b83d75eb103..0e555335f095 100644
--- a/kernel/trace/trace_hwlat.c
+++ b/kernel/trace/trace_hwlat.c
@@ -491,18 +491,14 @@ static void stop_per_cpu_kthreads(void)
static int start_cpu_kthread(unsigned int cpu)
{
struct task_struct *kthread;
- char comm[24];
- snprintf(comm, 24, "hwlatd/%d", cpu);
-
- kthread = kthread_create_on_cpu(kthread_fn, NULL, cpu, comm);
+ kthread = kthread_run_on_cpu(kthread_fn, NULL, cpu, "hwlatd/%u");
if (IS_ERR(kthread)) {
pr_err(BANNER "could not start sampling thread\n");
return -ENOMEM;
}
per_cpu(hwlat_per_cpu_data, cpu).kthread = kthread;
- wake_up_process(kthread);
return 0;
}
--
2.25.1
Repalce kthread_create/kthread_bind/wake_up_process()
with kthread_run_on_cpu() to simplify the code.
Signed-off-by: Cai Huoqing <[email protected]>
---
kernel/trace/ring_buffer.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index c5a3fbf19617..afb306e21e5b 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -5898,16 +5898,13 @@ static __init int test_ringbuffer(void)
rb_data[cpu].buffer = buffer;
rb_data[cpu].cpu = cpu;
rb_data[cpu].cnt = cpu;
- rb_threads[cpu] = kthread_create(rb_test, &rb_data[cpu],
- "rbtester/%d", cpu);
+ rb_threads[cpu] = kthread_run_on_cpu(rb_test, &rb_data[cpu],
+ cpu, "rbtester/%u");
if (WARN_ON(IS_ERR(rb_threads[cpu]))) {
pr_cont("FAILED\n");
ret = PTR_ERR(rb_threads[cpu]);
goto out_free;
}
-
- kthread_bind(rb_threads[cpu], cpu);
- wake_up_process(rb_threads[cpu]);
}
/* Now create the rb hammer! */
--
2.25.1
Repalce kthread_create/kthread_bind/wake_up_process()
with kthread_run_on_cpu() to simplify the code.
Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/infiniband/sw/siw/siw_main.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/sw/siw/siw_main.c b/drivers/infiniband/sw/siw/siw_main.c
index 9093e6a80b26..e5c586913d0b 100644
--- a/drivers/infiniband/sw/siw/siw_main.c
+++ b/drivers/infiniband/sw/siw/siw_main.c
@@ -98,15 +98,14 @@ static int siw_create_tx_threads(void)
continue;
siw_tx_thread[cpu] =
- kthread_create(siw_run_sq, (unsigned long *)(long)cpu,
- "siw_tx/%d", cpu);
+ kthread_run_on_cpu(siw_run_sq,
+ (unsigned long *)(long)cpu,
+ cpu, "siw_tx/%u");
if (IS_ERR(siw_tx_thread[cpu])) {
siw_tx_thread[cpu] = NULL;
continue;
}
- kthread_bind(siw_tx_thread[cpu], cpu);
- wake_up_process(siw_tx_thread[cpu]);
assigned++;
}
return assigned;
--
2.25.1
-----"Cai Huoqing" <[email protected]> wrote: -----
>To: <[email protected]>
>From: "Cai Huoqing" <[email protected]>
>Date: 10/21/2021 02:02PM
>Cc: "Bernard Metzler" <[email protected]>, "Doug Ledford"
><[email protected]>, "Jason Gunthorpe" <[email protected]>, "Davidlohr
>Bueso" <[email protected]>, "Paul E. McKenney" <[email protected]>,
>"Josh Triplett" <[email protected]>, "Steven Rostedt"
><[email protected]>, "Mathieu Desnoyers"
><[email protected]>, "Lai Jiangshan"
><[email protected]>, "Joel Fernandes" <[email protected]>,
>"Ingo Molnar" <[email protected]>, "Daniel Bristot de Oliveira"
><[email protected]>, <[email protected]>,
><[email protected]>, <[email protected]>
>Subject: [EXTERNAL] [PATCH 0/6] kthread: Add the helper macro
>kthread_run_on_cpu()
>
>the helper macro kthread_run_on_cpu() inculdes
>kthread_create_on_cpu/wake_up_process().
>In some cases, use kthread_run_on_cpu() directly instead of
>kthread_create_on_node/kthread_bind/wake_up_process() or
>kthread_create_on_cpu/wake_up_process() or
>kthreadd_create/kthread_bind/wake_up_process() to simplify the code.
I do not see kthread_bind() being covered by the helper,
as claimed? rcutorture, ring-buffer, siw are using it in
the code potentially being replaced by the helper.
kthread_bind() is best to be called before thread starts
running, so should be part of it.
Thanks,
Bernard.
>
>Cai Huoqing (6):
> kthread: Add the helper macro kthread_run_on_cpu()
> RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
> ring-buffer: Make use of the helper macro kthread_run_on_cpu()
> rcutorture: Make use of the helper macro kthread_run_on_cpu()
> trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
> trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
>
> drivers/infiniband/sw/siw/siw_main.c | 7 +++----
> include/linux/kthread.h | 22 ++++++++++++++++++++++
> kernel/rcu/rcutorture.c | 7 ++-----
> kernel/trace/ring_buffer.c | 7 ++-----
> kernel/trace/trace_hwlat.c | 6 +-----
> kernel/trace/trace_osnoise.c | 3 +--
> 6 files changed, 31 insertions(+), 21 deletions(-)
>
>--
>2.25.1
>
>
Hi, folks
V2 is here
https://lore.kernel.org/lkml/[email protected]/
> -----Original Message-----
> From: Cai,Huoqing <[email protected]>
> Sent: 2021??10??21?? 20:01
> To: Cai,Huoqing
> Cc: Bernard Metzler; Doug Ledford; Jason Gunthorpe; Davidlohr Bueso; Paul
> E. McKenney; Josh Triplett; Steven Rostedt; Mathieu Desnoyers; Lai
> Jiangshan; Joel Fernandes; Ingo Molnar; Daniel Bristot de Oliveira; linux-
> [email protected]; [email protected]; [email protected]
> Subject: [PATCH 0/6] kthread: Add the helper macro kthread_run_on_cpu()
>
> the helper macro kthread_run_on_cpu() inculdes
> kthread_create_on_cpu/wake_up_process().
> In some cases, use kthread_run_on_cpu() directly instead of
> kthread_create_on_node/kthread_bind/wake_up_process() or
> kthread_create_on_cpu/wake_up_process() or
> kthreadd_create/kthread_bind/wake_up_process() to simplify the code.
>
> Cai Huoqing (6):
> kthread: Add the helper macro kthread_run_on_cpu()
> RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
> ring-buffer: Make use of the helper macro kthread_run_on_cpu()
> rcutorture: Make use of the helper macro kthread_run_on_cpu()
> trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
> trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
>
> drivers/infiniband/sw/siw/siw_main.c | 7 +++----
> include/linux/kthread.h | 22 ++++++++++++++++++++++
> kernel/rcu/rcutorture.c | 7 ++-----
> kernel/trace/ring_buffer.c | 7 ++-----
> kernel/trace/trace_hwlat.c | 6 +-----
> kernel/trace/trace_osnoise.c | 3 +--
> 6 files changed, 31 insertions(+), 21 deletions(-)
>
> --
> 2.25.1
On 21 10月 21 13:48:15, Bernard Metzler wrote:
> -----"Cai Huoqing" <[email protected]> wrote: -----
>
> >To: <[email protected]>
> >From: "Cai Huoqing" <[email protected]>
> >Date: 10/21/2021 02:02PM
> >Cc: "Bernard Metzler" <[email protected]>, "Doug Ledford"
> ><[email protected]>, "Jason Gunthorpe" <[email protected]>, "Davidlohr
> >Bueso" <[email protected]>, "Paul E. McKenney" <[email protected]>,
> >"Josh Triplett" <[email protected]>, "Steven Rostedt"
> ><[email protected]>, "Mathieu Desnoyers"
> ><[email protected]>, "Lai Jiangshan"
> ><[email protected]>, "Joel Fernandes" <[email protected]>,
> >"Ingo Molnar" <[email protected]>, "Daniel Bristot de Oliveira"
> ><[email protected]>, <[email protected]>,
> ><[email protected]>, <[email protected]>
> >Subject: [EXTERNAL] [PATCH 0/6] kthread: Add the helper macro
> >kthread_run_on_cpu()
> >
> >the helper macro kthread_run_on_cpu() inculdes
> >kthread_create_on_cpu/wake_up_process().
> >In some cases, use kthread_run_on_cpu() directly instead of
> >kthread_create_on_node/kthread_bind/wake_up_process() or
> >kthread_create_on_cpu/wake_up_process() or
> >kthreadd_create/kthread_bind/wake_up_process() to simplify the code.
>
> I do not see kthread_bind() being covered by the helper,
> as claimed? rcutorture, ring-buffer, siw are using it in
> the code potentially being replaced by the helper.
> kthread_bind() is best to be called before thread starts
> running, so should be part of it.
Hi,
kthread_bind() is already part of kthread_create_on_cpu which is
called by kthread_run_on_cpu() here.
Thanks,
Cai.
>
> Thanks,
> Bernard.
> >
> >Cai Huoqing (6):
> > kthread: Add the helper macro kthread_run_on_cpu()
> > RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
> > ring-buffer: Make use of the helper macro kthread_run_on_cpu()
> > rcutorture: Make use of the helper macro kthread_run_on_cpu()
> > trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
> > trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
> >
> > drivers/infiniband/sw/siw/siw_main.c | 7 +++----
> > include/linux/kthread.h | 22 ++++++++++++++++++++++
> > kernel/rcu/rcutorture.c | 7 ++-----
> > kernel/trace/ring_buffer.c | 7 ++-----
> > kernel/trace/trace_hwlat.c | 6 +-----
> > kernel/trace/trace_osnoise.c | 3 +--
> > 6 files changed, 31 insertions(+), 21 deletions(-)
> >
> >--
> >2.25.1
> >
> >
-----"Cai Huoqing" <[email protected]> wrote: -----
>To: "Bernard Metzler" <[email protected]>
>From: "Cai Huoqing" <[email protected]>
>Date: 10/21/2021 04:08PM
>Cc: "Doug Ledford" <[email protected]>, "Jason Gunthorpe"
><[email protected]>, "Davidlohr Bueso" <[email protected]>, "Paul E.
>McKenney" <[email protected]>, "Josh Triplett"
><[email protected]>, "Steven Rostedt" <[email protected]>,
>"Mathieu Desnoyers" <[email protected]>, "Lai Jiangshan"
><[email protected]>, "Joel Fernandes" <[email protected]>,
>"Ingo Molnar" <[email protected]>, "Daniel Bristot de Oliveira"
><[email protected]>, <[email protected]>,
><[email protected]>, <[email protected]>
>Subject: [EXTERNAL] Re: [PATCH 0/6] kthread: Add the helper macro
>kthread_run_on_cpu()
>
>On 21 10月 21 13:48:15, Bernard Metzler wrote:
>> -----"Cai Huoqing" <[email protected]> wrote: -----
>>
>> >To: <[email protected]>
>> >From: "Cai Huoqing" <[email protected]>
>> >Date: 10/21/2021 02:02PM
>> >Cc: "Bernard Metzler" <[email protected]>, "Doug Ledford"
>> ><[email protected]>, "Jason Gunthorpe" <[email protected]>,
>"Davidlohr
>> >Bueso" <[email protected]>, "Paul E. McKenney"
><[email protected]>,
>> >"Josh Triplett" <[email protected]>, "Steven Rostedt"
>> ><[email protected]>, "Mathieu Desnoyers"
>> ><[email protected]>, "Lai Jiangshan"
>> ><[email protected]>, "Joel Fernandes"
><[email protected]>,
>> >"Ingo Molnar" <[email protected]>, "Daniel Bristot de Oliveira"
>> ><[email protected]>, <[email protected]>,
>> ><[email protected]>, <[email protected]>
>> >Subject: [EXTERNAL] [PATCH 0/6] kthread: Add the helper macro
>> >kthread_run_on_cpu()
>> >
>> >the helper macro kthread_run_on_cpu() inculdes
>> >kthread_create_on_cpu/wake_up_process().
>> >In some cases, use kthread_run_on_cpu() directly instead of
>> >kthread_create_on_node/kthread_bind/wake_up_process() or
>> >kthread_create_on_cpu/wake_up_process() or
>> >kthreadd_create/kthread_bind/wake_up_process() to simplify the
>code.
>>
>> I do not see kthread_bind() being covered by the helper,
>> as claimed? rcutorture, ring-buffer, siw are using it in
>> the code potentially being replaced by the helper.
>> kthread_bind() is best to be called before thread starts
>> running, so should be part of it.
>Hi,
>kthread_bind() is already part of kthread_create_on_cpu which is
>called by kthread_run_on_cpu() here.
>
Indeed! Thanks, Bernard.
>Thanks,
>Cai.
>>
>> Thanks,
>> Bernard.
>> >
>> >Cai Huoqing (6):
>> > kthread: Add the helper macro kthread_run_on_cpu()
>> > RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
>> > ring-buffer: Make use of the helper macro kthread_run_on_cpu()
>> > rcutorture: Make use of the helper macro kthread_run_on_cpu()
>> > trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
>> > trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
>> >
>> > drivers/infiniband/sw/siw/siw_main.c | 7 +++----
>> > include/linux/kthread.h | 22 ++++++++++++++++++++++
>> > kernel/rcu/rcutorture.c | 7 ++-----
>> > kernel/trace/ring_buffer.c | 7 ++-----
>> > kernel/trace/trace_hwlat.c | 6 +-----
>> > kernel/trace/trace_osnoise.c | 3 +--
>> > 6 files changed, 31 insertions(+), 21 deletions(-)
>> >
>> >--
>> >2.25.1
>> >
>> >
>