Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h.
Signed-off-by: Luo Jie <[email protected]>
---
drivers/net/phy/at803x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 3feee4d59030..b04fb251bacb 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -70,7 +70,6 @@
#define AT803X_CDT_STATUS_DELTA_TIME_MASK GENMASK(7, 0)
#define AT803X_LED_CONTROL 0x18
-#define AT803X_DEVICE_ADDR 0x03
#define AT803X_LOC_MAC_ADDR_0_15_OFFSET 0x804C
#define AT803X_LOC_MAC_ADDR_16_31_OFFSET 0x804B
#define AT803X_LOC_MAC_ADDR_32_47_OFFSET 0x804A
@@ -330,7 +329,8 @@ static int at803x_set_wol(struct phy_device *phydev,
const u8 *mac;
int ret;
u32 value;
- unsigned int i, offsets[] = {
+ unsigned int i;
+ const unsigned int offsets[] = {
AT803X_LOC_MAC_ADDR_32_47_OFFSET,
AT803X_LOC_MAC_ADDR_16_31_OFFSET,
AT803X_LOC_MAC_ADDR_0_15_OFFSET,
@@ -346,7 +346,7 @@ static int at803x_set_wol(struct phy_device *phydev,
return -EINVAL;
for (i = 0; i < 3; i++)
- phy_write_mmd(phydev, AT803X_DEVICE_ADDR, offsets[i],
+ phy_write_mmd(phydev, MDIO_MMD_PCS, offsets[i],
mac[(i * 2) + 1] | (mac[(i * 2)] << 8));
value = phy_read(phydev, AT803X_INTR_ENABLE);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Fri, Oct 22, 2021 at 08:06:11PM +0800, Luo Jie wrote:
> Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h.
>
> Signed-off-by: Luo Jie <[email protected]>
On v3, Andrew gave you a reviewed-by. You need to carry those forward
especially if the patches have not changed.
Reviewed-by: Russell King (Oracle) <[email protected]>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
On 10/22/2021 8:13 PM, Russell King (Oracle) wrote:
> On Fri, Oct 22, 2021 at 08:06:11PM +0800, Luo Jie wrote:
>> Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h.
>>
>> Signed-off-by: Luo Jie <[email protected]>
> On v3, Andrew gave you a reviewed-by. You need to carry those forward
> especially if the patches have not changed.
>
> Reviewed-by: Russell King (Oracle) <[email protected]>
Thanks Russell for this reminder, will follow it.
On Sat, Oct 23, 2021 at 09:53:15AM +0800, Jie Luo wrote:
>
> On 10/22/2021 8:13 PM, Russell King (Oracle) wrote:
> > On Fri, Oct 22, 2021 at 08:06:11PM +0800, Luo Jie wrote:
> > > Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h.
> > >
> > > Signed-off-by: Luo Jie <[email protected]>
> > On v3, Andrew gave you a reviewed-by. You need to carry those forward
> > especially if the patches have not changed.
> >
> > Reviewed-by: Russell King (Oracle) <[email protected]>
> Thanks Russell for this reminder, will follow it.
But, from what I can tell, you still haven't followed it in your v5
posting either.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!