2021-10-28 15:45:07

by Jiabing Wan

Subject: [PATCH v3] iio: adc: stm32-adc: Fix of_node_put() issue in stm32-adc

Fix following coccicheck warning:
./drivers/iio/adc/stm32-adc.c:2014:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter. Replace return by goto here.

Reviewed-by: Fabrice Gasnier <[email protected]>
Signed-off-by: Wan Jiabing <[email protected]>
---
Changelog:
v2:
- Fix typo and add reviewed-by.
v3:
- Fix typo.
---
drivers/iio/adc/stm32-adc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
index 6245434f8377..7f1fb36c747c 100644
--- a/drivers/iio/adc/stm32-adc.c
+++ b/drivers/iio/adc/stm32-adc.c
@@ -2024,7 +2024,8 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
if (strlen(name) >= STM32_ADC_CH_SZ) {
dev_err(&indio_dev->dev, "Label %s exceeds %d characters\n",
name, STM32_ADC_CH_SZ);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err;
}
strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ);
ret = stm32_adc_populate_int_ch(indio_dev, name, val);
--
2.33.1

2021-10-28 16:03:07

by Jonathan Cameron

Subject: Re: [PATCH v3] iio: adc: stm32-adc: Fix of_node_put() issue in stm32-adc

On Thu, 28 Oct 2021 23:42:02 +0800
Wan Jiabing <[email protected]> wrote:

> Fix following coccicheck warning:
> ./drivers/iio/adc/stm32-adc.c:2014:1-33: WARNING: Function
> for_each_available_child_of_node should have of_node_put() before return.
>
> Early exits from for_each_available_child_of_node should decrement the
> node reference counter. Replace return by goto here.
>
> Reviewed-by: Fabrice Gasnier <[email protected]>
> Signed-off-by: Wan Jiabing <[email protected]>
I applied v2. So no need to resend. I fix minor typos etc whilst
applying patches as it saves everyone time!

Thanks,

Jonathan

> ---
> Changelog:
> v2:
> - Fix typo and add reviewed-by.
> v3:
> - Fix typo.
> ---
> drivers/iio/adc/stm32-adc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index 6245434f8377..7f1fb36c747c 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -2024,7 +2024,8 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
> if (strlen(name) >= STM32_ADC_CH_SZ) {
> dev_err(&indio_dev->dev, "Label %s exceeds %d characters\n",
> name, STM32_ADC_CH_SZ);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto err;
> }
> strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ);
> ret = stm32_adc_populate_int_ch(indio_dev, name, val);