When RESET_TI_SYSCON is selected, and RESET_CONTROLLER
is not selected, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SCSI_UFS_MEDIATEK [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
This is because RESET_TI_SYSCON is selected by
SCSI_UFS_MEDIATEK, but SCSI_UFS_MEDIATEK does
not select or depend on RESET_CONTROLLER, despite
RESET_TI_SYSCON depending on RESET_CONTROLLER.
These unmet dependency bugs were detected by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.
Signed-off-by: Julian Braha <[email protected]>
---
drivers/scsi/ufs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index b2521b830be7..0427f8277a5d 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK
tristate "Mediatek specific hooks to UFS controller platform driver"
depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
select PHY_MTK_UFS
+ select RESET_CONTROLLER
select RESET_TI_SYSCON
help
This selects the Mediatek specific additions to UFSHCD platform driver.
--
2.30.2
On 10/28/21 13:35, Julian Braha wrote:
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index b2521b830be7..0427f8277a5d 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK
> tristate "Mediatek specific hooks to UFS controller platform driver"
> depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
> select PHY_MTK_UFS
> + select RESET_CONTROLLER
> select RESET_TI_SYSCON
> help
> This selects the Mediatek specific additions to UFSHCD platform driver.
Please keep the indentation consistent.
Thanks,
Bart.
> Please keep the indentation consistent.
>
> Thanks,
>
> Bart.
>
Hi Bart,
I have adjusted my text editor, and will resubmit the patch.
- Julian Braha