2021-11-02 02:15:50

by Jiabing Wan

Subject: [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR

Fix following coccicheck warning:
./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR
and PTR_ERR on line 490.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 1a19ebad60ad..63259b3ea5ab 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -487,7 +487,7 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev)
pcc_chan = pcc_mbox_request_channel(cl, ctx->mbox_idx);
if (IS_ERR(pcc_chan)) {
dev_err(&pdev->dev, "PCC mailbox channel request failed\n");
- return PTR_ERR(ctx->pcc_chan);
+ return PTR_ERR(pcc_chan);
}

ctx->pcc_chan = pcc_chan;
--
2.20.1

2021-11-02 09:03:38

by Sudeep Holla

Subject: Re: [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR

Hi Wan,

On Mon, Nov 01, 2021 at 10:12:27PM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR
> and PTR_ERR on line 490.

There is another version @[1]. Thanks for the effort.

Hi Wolfram,

Can you pick [1] after -rc1 ? I see mailbox updates are in the mainline
already.

--
Regards,
Sudeep

[1] https://lore.kernel.org/kernel-janitors/[email protected]/