2021-11-02 14:18:04

by Mark-PK Tsai (蔡沛剛)

Subject: [PATCH v2] remoteproc: use %pe format string to print return error code

Use %pe format string to print return error code which
make the error message easier to understand.

Signed-off-by: Mark-PK Tsai <[email protected]>
---
drivers/remoteproc/remoteproc_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 502b6604b757..2242da320368 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
dma_get_mask(rproc->dev.parent));
if (ret) {
dev_warn(dev,
- "Failed to set DMA mask %llx. Trying to continue... %x\n",
- dma_get_mask(rproc->dev.parent), ret);
+ "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
+ dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
}

/* parse the vrings */
--
2.18.0

2021-11-11 18:18:35

by Mathieu Poirier

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

Hi Mark,

On Tue, 2 Nov 2021 at 08:15, Mark-PK Tsai <[email protected]> wrote:
>
> Use %pe format string to print return error code which
> make the error message easier to understand.
>
> Signed-off-by: Mark-PK Tsai <[email protected]>
> ---
> drivers/remoteproc/remoteproc_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 502b6604b757..2242da320368 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> dma_get_mask(rproc->dev.parent));
> if (ret) {
> dev_warn(dev,
> - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> - dma_get_mask(rproc->dev.parent), ret);
> + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));

Macro ERR_PTR() is used to convert error codes to pointer type when
returning from a function - I fail to see how doing so in a dev_warn()
context can make the message easier to understand. Can you provide an
example?

Thanks,
Mathieu

> }
>
> /* parse the vrings */
> --
> 2.18.0
>

2021-11-12 02:13:19

by Mark-PK Tsai (蔡沛剛)

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

> Hi Mark,
>
>
> >
> > Use %pe format string to print return error code which
> > make the error message easier to understand.
> >
> > Signed-off-by: Mark-PK Tsai <[email protected]>
> > ---
> > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > index 502b6604b757..2242da320368 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> > dma_get_mask(rproc->dev.parent));
> > if (ret) {
> > dev_warn(dev,
> > - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > - dma_get_mask(rproc->dev.parent), ret);
> > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
>
> Macro ERR_PTR() is used to convert error codes to pointer type when
> returning from a function - I fail to see how doing so in a dev_warn()
> context can make the message easier to understand. Can you provide an
> example?

Hi,

When dma_coerce_mask_and_coherent() fail, the output log will be as following.

format log
%x Trying to continue... fffffffb
%d Trying to continue... -5
%pe Trying to continue... -5 (if CONFIG_SYMBOLIC_ERRNAME is not set)
%pe Trying to continue... -EIO (if CONFIG_SYMBOLIC_ERRNAME=y)

2021-11-12 16:25:56

by Mathieu Poirier

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

On Thu, 11 Nov 2021 at 19:13, Mark-PK Tsai <[email protected]> wrote:
>
> > Hi Mark,
> >
> >
> > >
> > > Use %pe format string to print return error code which
> > > make the error message easier to understand.
> > >
> > > Signed-off-by: Mark-PK Tsai <[email protected]>
> > > ---
> > > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > > index 502b6604b757..2242da320368 100644
> > > --- a/drivers/remoteproc/remoteproc_core.c
> > > +++ b/drivers/remoteproc/remoteproc_core.c
> > > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> > > dma_get_mask(rproc->dev.parent));
> > > if (ret) {
> > > dev_warn(dev,
> > > - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > > - dma_get_mask(rproc->dev.parent), ret);
> > > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
> >
> > Macro ERR_PTR() is used to convert error codes to pointer type when
> > returning from a function - I fail to see how doing so in a dev_warn()
> > context can make the message easier to understand. Can you provide an
> > example?
>
> Hi,
>
> When dma_coerce_mask_and_coherent() fail, the output log will be as following.
>
> format log
> %x Trying to continue... fffffffb
> %d Trying to continue... -5
> %pe Trying to continue... -5 (if CONFIG_SYMBOLIC_ERRNAME is not set)
> %pe Trying to continue... -EIO (if CONFIG_SYMBOLIC_ERRNAME=y)

When failing, functions dma_coerce_mask_and_coherent() returns -EIO.
Casting that to a (void *) with ERR_PTR() does not change that value.
Since variable @ret is already declared as "int" the real fix is to
change "%x" to "%d".

2021-11-16 13:57:08

by Mark-PK Tsai (蔡沛剛)

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

> > > > Use %pe format string to print return error code which
> > > > make the error message easier to understand.
> > > >
> > > > Signed-off-by: Mark-PK Tsai <[email protected]>
> > > > ---
> > > > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > > > index 502b6604b757..2242da320368 100644
> > > > --- a/drivers/remoteproc/remoteproc_core.c
> > > > +++ b/drivers/remoteproc/remoteproc_core.c
> > > > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> > > > dma_get_mask(rproc->dev.parent));
> > > > if (ret) {
> > > > dev_warn(dev,
> > > > - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > > > - dma_get_mask(rproc->dev.parent), ret);
> > > > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > > > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
> > >
> > > Macro ERR_PTR() is used to convert error codes to pointer type when
> > > returning from a function - I fail to see how doing so in a dev_warn()
> > > context can make the message easier to understand. Can you provide an
> > > example?
> >
> > Hi,
> >
> > When dma_coerce_mask_and_coherent() fail, the output log will be as following.
> >
> > format log
> > %x Trying to continue... fffffffb
> > %d Trying to continue... -5
> > %pe Trying to continue... -5 (if CONFIG_SYMBOLIC_ERRNAME is not set)
> > %pe Trying to continue... -EIO (if CONFIG_SYMBOLIC_ERRNAME=y)
>
> When failing, functions dma_coerce_mask_and_coherent() returns -EIO.
> Casting that to a (void *) with ERR_PTR() does not change that value.
> Since variable @ret is already declared as "int" the real fix is to
> change "%x" to "%d".

There're some other drivers do the same thing in the recent kernel, so I think
it's fine to casting the `ret` to a (void *) for more user friendly.
But I suppose it would depend on the maintainer's opinion.

So how about previous patch I sent, which also fix this issue by using %d.

https://lore.kernel.org/lkml/[email protected]/

2021-11-16 16:29:39

by Mathieu Poirier

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

Good day,

On Tue, Nov 16, 2021 at 09:57:03PM +0800, Mark-PK Tsai wrote:
> > > > > Use %pe format string to print return error code which
> > > > > make the error message easier to understand.
> > > > >
> > > > > Signed-off-by: Mark-PK Tsai <[email protected]>
> > > > > ---
> > > > > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > > > > index 502b6604b757..2242da320368 100644
> > > > > --- a/drivers/remoteproc/remoteproc_core.c
> > > > > +++ b/drivers/remoteproc/remoteproc_core.c
> > > > > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> > > > > dma_get_mask(rproc->dev.parent));
> > > > > if (ret) {
> > > > > dev_warn(dev,
> > > > > - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > > > > - dma_get_mask(rproc->dev.parent), ret);
> > > > > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > > > > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
> > > >
> > > > Macro ERR_PTR() is used to convert error codes to pointer type when
> > > > returning from a function - I fail to see how doing so in a dev_warn()
> > > > context can make the message easier to understand. Can you provide an
> > > > example?
> > >
> > > Hi,
> > >
> > > When dma_coerce_mask_and_coherent() fail, the output log will be as following.
> > >
> > > format log
> > > %x Trying to continue... fffffffb
> > > %d Trying to continue... -5
> > > %pe Trying to continue... -5 (if CONFIG_SYMBOLIC_ERRNAME is not set)
> > > %pe Trying to continue... -EIO (if CONFIG_SYMBOLIC_ERRNAME=y)
> >
> > When failing, functions dma_coerce_mask_and_coherent() returns -EIO.
> > Casting that to a (void *) with ERR_PTR() does not change that value.
> > Since variable @ret is already declared as "int" the real fix is to
> > change "%x" to "%d".
>
> There're some other drivers do the same thing in the recent kernel, so I think
> it's fine to casting the `ret` to a (void *) for more user friendly.
> But I suppose it would depend on the maintainer's opinion.
>
> So how about previous patch I sent, which also fix this issue by using %d.
>
> https://lore.kernel.org/lkml/[email protected]/

I had not seen Russell's reply in the link you posted above. I am not
completely sure about his solution but his insight and guidance in kernel
programming have precedence over mine.

I will take this patch.

Thanks,
Mathieu


>

2021-11-17 14:59:14

by Bjorn Andersson

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

On Tue 02 Nov 09:15 CDT 2021, Mark-PK Tsai wrote:

> Use %pe format string to print return error code which
> make the error message easier to understand.
>

Reviewed-by: Bjorn Andersson <[email protected]>

> Signed-off-by: Mark-PK Tsai <[email protected]>
> ---
> drivers/remoteproc/remoteproc_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 502b6604b757..2242da320368 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> dma_get_mask(rproc->dev.parent));
> if (ret) {
> dev_warn(dev,
> - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> - dma_get_mask(rproc->dev.parent), ret);
> + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
> }
>
> /* parse the vrings */
> --
> 2.18.0
>

2021-12-13 07:20:22

by Mark-PK Tsai (蔡沛剛)

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

> Good day,
>
> On Tue, Nov 16, 2021 at 09:57:03PM +0800, Mark-PK Tsai wrote:
> > > > > > Use %pe format string to print return error code which
> > > > > > make the error message easier to understand.
> > > > > >
> > > > > > Signed-off-by: Mark-PK Tsai <[email protected]>
> > > > > > ---
> > > > > > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > > > > > index 502b6604b757..2242da320368 100644
> > > > > > --- a/drivers/remoteproc/remoteproc_core.c
> > > > > > +++ b/drivers/remoteproc/remoteproc_core.c
> > > > > > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> > > > > > dma_get_mask(rproc->dev.parent));
> > > > > > if (ret) {
> > > > > > dev_warn(dev,
> > > > > > - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > > > > > - dma_get_mask(rproc->dev.parent), ret);
> > > > > > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > > > > > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
> > > > >
> > > > > Macro ERR_PTR() is used to convert error codes to pointer type when
> > > > > returning from a function - I fail to see how doing so in a dev_warn()
> > > > > context can make the message easier to understand. Can you provide an
> > > > > example?
> > > >
> > > > Hi,
> > > >
> > > > When dma_coerce_mask_and_coherent() fail, the output log will be as following.
> > > >
> > > > format log
> > > > %x Trying to continue... fffffffb
> > > > %d Trying to continue... -5
> > > > %pe Trying to continue... -5 (if CONFIG_SYMBOLIC_ERRNAME is not set)
> > > > %pe Trying to continue... -EIO (if CONFIG_SYMBOLIC_ERRNAME=y)
> > >
> > > When failing, functions dma_coerce_mask_and_coherent() returns -EIO.
> > > Casting that to a (void *) with ERR_PTR() does not change that value.
> > > Since variable @ret is already declared as "int" the real fix is to
> > > change "%x" to "%d".
> >
> > There're some other drivers do the same thing in the recent kernel, so I think
> > it's fine to casting the `ret` to a (void *) for more user friendly.
> > But I suppose it would depend on the maintainer's opinion.
> >
> > So how about previous patch I sent, which also fix this issue by using %d.
> >
> > https://lore.kernel.org/lkml/[email protected]/
>
> I had not seen Russell's reply in the link you posted above. I am not
> completely sure about his solution but his insight and guidance in kernel
> programming have precedence over mine.
>
> I will take this patch.
>
> Thanks,
> Mathieu
>

Hi,

Sorry to disturb you.
Is this patch queued?
Just want to make sure it has not been forgotten.

2021-12-13 16:55:59

by Mathieu Poirier

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

On Mon, Dec 13, 2021 at 03:20:15PM +0800, Mark-PK Tsai wrote:
> > Good day,
> >
> > On Tue, Nov 16, 2021 at 09:57:03PM +0800, Mark-PK Tsai wrote:
> > > > > > > Use %pe format string to print return error code which
> > > > > > > make the error message easier to understand.
> > > > > > >
> > > > > > > Signed-off-by: Mark-PK Tsai <[email protected]>
> > > > > > > ---
> > > > > > > drivers/remoteproc/remoteproc_core.c | 4 ++--
> > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > > > > > > index 502b6604b757..2242da320368 100644
> > > > > > > --- a/drivers/remoteproc/remoteproc_core.c
> > > > > > > +++ b/drivers/remoteproc/remoteproc_core.c
> > > > > > > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
> > > > > > > dma_get_mask(rproc->dev.parent));
> > > > > > > if (ret) {
> > > > > > > dev_warn(dev,
> > > > > > > - "Failed to set DMA mask %llx. Trying to continue... %x\n",
> > > > > > > - dma_get_mask(rproc->dev.parent), ret);
> > > > > > > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n",
> > > > > > > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret));
> > > > > >
> > > > > > Macro ERR_PTR() is used to convert error codes to pointer type when
> > > > > > returning from a function - I fail to see how doing so in a dev_warn()
> > > > > > context can make the message easier to understand. Can you provide an
> > > > > > example?
> > > > >
> > > > > Hi,
> > > > >
> > > > > When dma_coerce_mask_and_coherent() fail, the output log will be as following.
> > > > >
> > > > > format log
> > > > > %x Trying to continue... fffffffb
> > > > > %d Trying to continue... -5
> > > > > %pe Trying to continue... -5 (if CONFIG_SYMBOLIC_ERRNAME is not set)
> > > > > %pe Trying to continue... -EIO (if CONFIG_SYMBOLIC_ERRNAME=y)
> > > >
> > > > When failing, functions dma_coerce_mask_and_coherent() returns -EIO.
> > > > Casting that to a (void *) with ERR_PTR() does not change that value.
> > > > Since variable @ret is already declared as "int" the real fix is to
> > > > change "%x" to "%d".
> > >
> > > There're some other drivers do the same thing in the recent kernel, so I think
> > > it's fine to casting the `ret` to a (void *) for more user friendly.
> > > But I suppose it would depend on the maintainer's opinion.
> > >
> > > So how about previous patch I sent, which also fix this issue by using %d.
> > >
> > > https://lore.kernel.org/lkml/[email protected]/
> >
> > I had not seen Russell's reply in the link you posted above. I am not
> > completely sure about his solution but his insight and guidance in kernel
> > programming have precedence over mine.
> >
> > I will take this patch.
> >
> > Thanks,
> > Mathieu
> >
>
> Hi,
>
> Sorry to disturb you.
> Is this patch queued?
> Just want to make sure it has not been forgotten.

https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/log/?h=for-next

2021-12-14 01:31:20

by Mark-PK Tsai (蔡沛剛)

Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code

>
> https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/log/?h=for-next
>

Got it, thanks!