2021-11-03 01:47:47

by He Ying

Subject: [PATCH] powerpc/sysdev/of_rtc: Fix possible memory leak in of_instantiate_rtc

If of_address_to_resource() in of_instantiate_rtc() fails, previously
allocated memory res is not freed. Add missing kfree() for it.

Signed-off-by: He Ying <[email protected]>
---
arch/powerpc/sysdev/of_rtc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/sysdev/of_rtc.c b/arch/powerpc/sysdev/of_rtc.c
index 1f408d34a6a7..23b896996c2f 100644
--- a/arch/powerpc/sysdev/of_rtc.c
+++ b/arch/powerpc/sysdev/of_rtc.c
@@ -44,6 +44,7 @@ void __init of_instantiate_rtc(void)
printk(KERN_ERR "OF RTC: Error "
"translating resources for %pOF\n",
node);
+ kfree(res);
continue;
}

--
2.17.1

2021-12-27 03:53:12

by He Ying

Subject: Re: [PATCH] powerpc/sysdev/of_rtc: Fix possible memory leak in of_instantiate_rtc

Ping. Any ideas about this patch?

?? 2021/11/3 9:47, He Ying д??:
> If of_address_to_resource() in of_instantiate_rtc() fails, previously
> allocated memory res is not freed. Add missing kfree() for it.
>
> Signed-off-by: He Ying <[email protected]>
> ---
> arch/powerpc/sysdev/of_rtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/sysdev/of_rtc.c b/arch/powerpc/sysdev/of_rtc.c
> index 1f408d34a6a7..23b896996c2f 100644
> --- a/arch/powerpc/sysdev/of_rtc.c
> +++ b/arch/powerpc/sysdev/of_rtc.c
> @@ -44,6 +44,7 @@ void __init of_instantiate_rtc(void)
> printk(KERN_ERR "OF RTC: Error "
> "translating resources for %pOF\n",
> node);
> + kfree(res);
> continue;
> }
>