2021-11-09 23:48:11

by Cai,Huoqing

Subject: [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM

The helper function devm_platform_ioremap_resource_xxx()
needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/mtd/nand/raw/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 67b7cb67c030..0a45d3c6c15b 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -26,7 +26,7 @@ config MTD_NAND_DENALI_PCI
config MTD_NAND_DENALI_DT
tristate "Denali NAND controller as a DT device"
select MTD_NAND_DENALI
- depends on HAS_DMA && HAVE_CLK && OF
+ depends on HAS_DMA && HAVE_CLK && OF && HAS_IOMEM
help
Enable the driver for NAND flash on platforms using a Denali NAND
controller as a DT device.
--
2.25.1

2021-11-09 23:52:09

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM

Hi Cai,

[email protected] wrote on Tue, 9 Nov 2021 20:54:55 +0800:

> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---

Can you please add a Fixes tag?

> drivers/mtd/nand/raw/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..0a45d3c6c15b 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -26,7 +26,7 @@ config MTD_NAND_DENALI_PCI
> config MTD_NAND_DENALI_DT
> tristate "Denali NAND controller as a DT device"
> select MTD_NAND_DENALI
> - depends on HAS_DMA && HAVE_CLK && OF
> + depends on HAS_DMA && HAVE_CLK && OF && HAS_IOMEM
> help
> Enable the driver for NAND flash on platforms using a Denali NAND
> controller as a DT device.


Thanks,
Miquèl