2021-11-23 08:23:22

by Wei Yongjun

Subject: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()

The driver allocates the mutex but not initialize it.
Use mutex_init() on it to initialize it correctly.

Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/firmware/arm_scmi/optee.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
index d9819b0197ec..901737c9f5f8 100644
--- a/drivers/firmware/arm_scmi/optee.c
+++ b/drivers/firmware/arm_scmi/optee.c
@@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
agent->dev = dev;
agent->tee_ctx = tee_ctx;
INIT_LIST_HEAD(&agent->channel_list);
+ mutex_init(&agent->mu);

ret = get_capabilities(agent);
if (ret)

2021-11-23 13:18:11

by Etienne Carriere

Subject: Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()

On Tue, 23 Nov 2021 at 09:23, Wei Yongjun <[email protected]> wrote:
>
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
> Fixes: 5f90f189a052 ("firmware: arm_scmi: Add optee transport")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/firmware/arm_scmi/optee.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c
> index d9819b0197ec..901737c9f5f8 100644
> --- a/drivers/firmware/arm_scmi/optee.c
> +++ b/drivers/firmware/arm_scmi/optee.c
> @@ -506,6 +506,7 @@ static int scmi_optee_service_probe(struct device *dev)
> agent->dev = dev;
> agent->tee_ctx = tee_ctx;
> INIT_LIST_HEAD(&agent->channel_list);
> + mutex_init(&agent->mu);
>
> ret = get_capabilities(agent);
> if (ret)
>

`Reviewed-by: Etienne Carriere <[email protected]>`

Indeed. Thanks for the fix.
Etienne

2021-11-25 12:38:15

by Sudeep Holla

Subject: Re: [PATCH -next] firmware: arm_scmi: optee: Fix missing mutex_init()

On Tue, 23 Nov 2021 08:36:20 +0000, Wei Yongjun wrote:
> The driver allocates the mutex but not initialize it.
> Use mutex_init() on it to initialize it correctly.
>
>

Applied to sudeep.holla/linux (for-next/scmi), thanks!

[1/1] firmware: arm_scmi: optee: Fix missing mutex_init()
https://git.kernel.org/sudeep.holla/c/61bc76be36

--
Regards,
Sudeep