2021-11-24 14:52:12

by Dan Carpenter

Subject: [PATCH] mailbox: imx: Fix an IS_ERR() vs NULL bug

The devm_kzalloc() function does not return error pointers, it returns
NULL on failure.

Fixes: 97961f78e8bc ("mailbox: imx: support i.MX8ULP S4 MU")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/mailbox/imx-mailbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index ffe36a6bef9e..544de2db6453 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -563,8 +563,8 @@ static int imx_mu_probe(struct platform_device *pdev)
size = sizeof(struct imx_sc_rpc_msg_max);

priv->msg = devm_kzalloc(dev, size, GFP_KERNEL);
- if (IS_ERR(priv->msg))
- return PTR_ERR(priv->msg);
+ if (!priv->msg)
+ return -ENOMEM;

priv->clk = devm_clk_get(dev, NULL);
if (IS_ERR(priv->clk)) {
--
2.20.1

2021-11-25 00:29:46

by Peng Fan

Subject: RE: [PATCH] mailbox: imx: Fix an IS_ERR() vs NULL bug

> Subject: [PATCH] mailbox: imx: Fix an IS_ERR() vs NULL bug
>
> The devm_kzalloc() function does not return error pointers, it returns NULL on
> failure.
>
> Fixes: 97961f78e8bc ("mailbox: imx: support i.MX8ULP S4 MU")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Peng Fan <[email protected]>

> ---
> drivers/mailbox/imx-mailbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index ffe36a6bef9e..544de2db6453 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -563,8 +563,8 @@ static int imx_mu_probe(struct platform_device
> *pdev)
> size = sizeof(struct imx_sc_rpc_msg_max);
>
> priv->msg = devm_kzalloc(dev, size, GFP_KERNEL);
> - if (IS_ERR(priv->msg))
> - return PTR_ERR(priv->msg);
> + if (!priv->msg)
> + return -ENOMEM;
>
> priv->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(priv->clk)) {
> --
> 2.20.1