2021-12-03 11:52:18

by Yihao Han

[permalink] [raw]
Subject: [PATCH] scsi: pmcraid: Replace snprintf in show functions with sysfs_emit

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Yihao Han <[email protected]>
---
drivers/scsi/pmcraid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 2fe7a0019fff..551713d33838 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3984,7 +3984,7 @@ static ssize_t pmcraid_show_log_level(
struct Scsi_Host *shost = class_to_shost(dev);
struct pmcraid_instance *pinstance =
(struct pmcraid_instance *)shost->hostdata;
- return snprintf(buf, PAGE_SIZE, "%d\n", pinstance->current_log_level);
+ return sysfs_emit(buf, "%d\n", pinstance->current_log_level);
}

/**
@@ -4045,7 +4045,7 @@ static ssize_t pmcraid_show_drv_version(
char *buf
)
{
- return snprintf(buf, PAGE_SIZE, "version: %s\n",
+ return sysfs_emit(buf, "version: %s\n",
PMCRAID_DRIVER_VERSION);
}

@@ -4079,7 +4079,7 @@ static ssize_t pmcraid_show_adapter_id(
pinstance->pdev->devfn;
u32 aen_group = pmcraid_event_family.id;

- return snprintf(buf, PAGE_SIZE,
+ return sysfs_emit(buf,
"adapter id: %d\nminor: %d\naen group: %d\n",
adapter_id, MINOR(pinstance->cdev.dev), aen_group);
}
--
2.17.1