2021-12-05 23:55:36

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the bpf-next tree

Hi all,

After merging the bpf-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

kernel/bpf/btf.c:6588:13: warning: 'purge_cand_cache' defined but not used [-Wunused-function]
6588 | static void purge_cand_cache(struct btf *btf)
| ^~~~~~~~~~~~~~~~

Introduced by commit

1e89106da253 ("bpf: Add bpf_core_add_cands() and wire it into bpf_core_apply_relo_insn().")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2021-12-06 00:43:55

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the bpf-next tree

Hi all,

On Mon, 6 Dec 2021 10:55:30 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the bpf-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> kernel/bpf/btf.c:6588:13: warning: 'purge_cand_cache' defined but not used [-Wunused-function]
> 6588 | static void purge_cand_cache(struct btf *btf)
> | ^~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 1e89106da253 ("bpf: Add bpf_core_add_cands() and wire it into bpf_core_apply_relo_insn().")

And this is a build failure for my x86_64 allmodconfig build. So I
have used the bpf-next tree from next-20211202 again.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2021-12-07 03:23:12

by Andrii Nakryiko

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the bpf-next tree

On Sun, Dec 5, 2021 at 4:44 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Mon, 6 Dec 2021 10:55:30 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the bpf-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > kernel/bpf/btf.c:6588:13: warning: 'purge_cand_cache' defined but not used [-Wunused-function]
> > 6588 | static void purge_cand_cache(struct btf *btf)
> > | ^~~~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> > 1e89106da253 ("bpf: Add bpf_core_add_cands() and wire it into bpf_core_apply_relo_insn().")
>
> And this is a build failure for my x86_64 allmodconfig build. So I
> have used the bpf-next tree from next-20211202 again.

This should be fixed by [0] which I just applied to bpf-next, thanks
for letting us know! The reason you noticed this and we didn't is
because your version of pahole is probably older than what we use
typically and doesn't yet support kernel module BTFs.

[0] https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/


>
> --
> Cheers,
> Stephen Rothwell