2021-12-06 22:40:58

by Thomas Gleixner

Subject: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <[email protected]>
---
V2: Invoke the function with the correct number of arguments - Andy
---
arch/powerpc/platforms/cell/axon_msi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -199,7 +199,7 @@ static struct axon_msic *find_msi_transl
static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
{
struct device_node *dn;
- struct msi_desc *entry;
+ bool is_64bit;
int len;
const u32 *prop;

@@ -209,10 +209,10 @@ static int setup_msi_msg_address(struct
return -ENODEV;
}

- entry = first_pci_msi_entry(dev);
+ is_64bit = msi_device_has_property(&dev->dev, MSI_PROP_64BIT);

for (; dn; dn = of_get_next_parent(dn)) {
- if (entry->pci.msi_attrib.is_64) {
+ if (is_64bit) {
prop = of_get_property(dn, "msi-address-64", &len);
if (prop)
break;

2021-12-07 07:52:22

by Greg Kroah-Hartman

Subject: Re: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties

On Mon, Dec 06, 2021 at 11:39:33PM +0100, Thomas Gleixner wrote:
> instead of fiddling with MSI descriptors.
>
> Signed-off-by: Thomas Gleixner <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2021-12-08 15:54:49

by Jason Gunthorpe

Subject: Re: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties

On Mon, Dec 06, 2021 at 11:39:33PM +0100, Thomas Gleixner wrote:

> @@ -209,10 +209,10 @@ static int setup_msi_msg_address(struct
> return -ENODEV;
> }
>
> - entry = first_pci_msi_entry(dev);
> + is_64bit = msi_device_has_property(&dev->dev, MSI_PROP_64BIT);

How about !dev->no_64bit_msi ?

Jason