2021-12-10 13:58:05

by Xiang wangx

Subject: [PATCH v2] gpio: bcm-kona: add const to of_device_id

struct of_device_id should normally be const.

Signed-off-by: Xiang wangx <[email protected]>
---

Changes since v1
* Change subject log

drivers/gpio/gpio-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index d329a143f5ec..9cb3587d1441 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -505,7 +505,7 @@ static struct irq_chip bcm_gpio_irq_chip = {
.irq_release_resources = bcm_kona_gpio_irq_relres,
};

-static struct of_device_id const bcm_kona_gpio_of_match[] = {
+static const struct of_device_id const bcm_kona_gpio_of_match[] = {
{ .compatible = "brcm,kona-gpio" },
{}
};
--
2.20.1

2021-12-10 15:18:03

by Bartosz Golaszewski

Subject: Re: [PATCH v2] gpio: bcm-kona: add const to of_device_id

On Fri, Dec 10, 2021 at 2:57 PM Xiang wangx <[email protected]> wrote:
>
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <[email protected]>
> ---
>
> Changes since v1
> * Change subject log
>
> drivers/gpio/gpio-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index d329a143f5ec..9cb3587d1441 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -505,7 +505,7 @@ static struct irq_chip bcm_gpio_irq_chip = {
> .irq_release_resources = bcm_kona_gpio_irq_relres,
> };
>
> -static struct of_device_id const bcm_kona_gpio_of_match[] = {
> +static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> { .compatible = "brcm,kona-gpio" },
> {}
> };
> --
> 2.20.1
>

Applied, thanks!

Bart

PS: next time please include any ack/review tags already left under
the previous version