kernel test robot complains about missing FIELD_PREP, so include
bitfield.h for that
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
Reported-by: kernel test robot <[email protected]>
Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
Signed-off-by: Vinod Koul <[email protected]>
---
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index f6502463d49a..04b1aafb29f4 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -3,6 +3,7 @@
* Copyright 2021 NXP
*/
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/iopoll.h>
--
2.31.1
> -----Original Message-----
> From: Vinod Koul <[email protected]>
> Sent: Wednesday, December 15, 2021 2:09 PM
> To: Kishon Vijay Abraham I <[email protected]>; Hongxing Zhu
> <[email protected]>
> Cc: [email protected]; Vinod Koul <[email protected]>;
> [email protected]; [email protected];
> kernel test robot <[email protected]>
> Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
>
> kernel test robot complains about missing FIELD_PREP, so include
> bitfield.h for that
>
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver")
> Signed-off-by: Vinod Koul <[email protected]>
Reviewed-by: Richard Zhu <[email protected]>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and tests.
Best Regards
Richard Zhu
> ---
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index f6502463d49a..04b1aafb29f4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -3,6 +3,7 @@
> * Copyright 2021 NXP
> */
>
> +#include <linux/bitfield.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> --
> 2.31.1
On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <[email protected]>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <[email protected]>; Hongxing Zhu
> > <[email protected]>
> > Cc: [email protected]; Vinod Koul <[email protected]>;
> > [email protected]; [email protected];
> > kernel test robot <[email protected]>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> >
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> >
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> >
> > Reported-by: kernel test robot <[email protected]>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <[email protected]>
> Reviewed-by: Richard Zhu <[email protected]>
Thanks for quick review, I have pushed this
> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.
No worries, Do test on different arch's other than yours
--
~Vinod