2021-12-15 15:57:17

by David Heidelberg

Subject: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

Properties #address-cells and #size-cells are valid.
The bridge node can also contains panel node.

Signed-off-by: David Heidelberg <[email protected]>
---
.../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
index eacfe7165083..3186d9dffd98 100644
--- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
@@ -69,6 +69,16 @@ properties:
- port@0
- port@1

+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
+patternProperties:
+ "^panel@[0-3]$":
+ $ref: ../panel/panel-common.yaml
+
required:
- compatible
- reg
--
2.34.1

2021-12-15 17:39:22

by Dmitry Osipenko

Subject: Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

15.12.2021 18:27, David Heidelberg пишет:
> Properties #address-cells and #size-cells are valid.
> The bridge node can also contains panel node.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> index eacfe7165083..3186d9dffd98 100644
> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> @@ -69,6 +69,16 @@ properties:
> - port@0
> - port@1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +patternProperties:
> + "^panel@[0-3]$":
> + $ref: ../panel/panel-common.yaml

The panel is always fixed to port 1, isn't it? Shouldn't it be just
port@1 here?

2021-12-15 22:27:36

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

On Wed, 15 Dec 2021 16:27:12 +0100, David Heidelberg wrote:
> Properties #address-cells and #size-cells are valid.
> The bridge node can also contains panel node.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1568330


tc358778@e: compatible: Additional items are not allowed ('toshiba,tc358768' was unexpected)
arch/arm/boot/dts/am571x-idk.dt.yaml
arch/arm/boot/dts/am572x-idk.dt.yaml
arch/arm/boot/dts/am574x-idk.dt.yaml

tc358778@e: compatible: ['toshiba,tc358778', 'toshiba,tc358768'] is too long
arch/arm/boot/dts/am571x-idk.dt.yaml
arch/arm/boot/dts/am572x-idk.dt.yaml
arch/arm/boot/dts/am574x-idk.dt.yaml

2021-12-16 15:13:21

by Rob Herring

Subject: Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

On Wed, Dec 15, 2021 at 9:38 AM David Heidelberg <[email protected]> wrote:
>
> Properties #address-cells and #size-cells are valid.
> The bridge node can also contains panel node.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> index eacfe7165083..3186d9dffd98 100644
> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> @@ -69,6 +69,16 @@ properties:
> - port@0
> - port@1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +patternProperties:
> + "^panel@[0-3]$":
> + $ref: ../panel/panel-common.yaml

It's possible to attach something that doesn't use panel-common.yaml
and if it did, it would be applied by that schema.

What you need is to just reference dsi-controller.yaml at the top level.

Rob

2021-12-16 16:42:45

by Dmitry Osipenko

Subject: Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

16.12.2021 18:13, Rob Herring пишет:
> On Wed, Dec 15, 2021 at 9:38 AM David Heidelberg <[email protected]> wrote:
>>
>> Properties #address-cells and #size-cells are valid.
>> The bridge node can also contains panel node.
>>
>> Signed-off-by: David Heidelberg <[email protected]>
>> ---
>> .../bindings/display/bridge/toshiba,tc358768.yaml | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> index eacfe7165083..3186d9dffd98 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> @@ -69,6 +69,16 @@ properties:
>> - port@0
>> - port@1
>>
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> +patternProperties:
>> + "^panel@[0-3]$":
>> + $ref: ../panel/panel-common.yaml
>
> It's possible to attach something that doesn't use panel-common.yaml
> and if it did, it would be applied by that schema.
>
> What you need is to just reference dsi-controller.yaml at the top level.

It works, thank you.

Then we will also need to rename the "dsi-bridge" node to just "dsi" in
the new ASUS TF700T device-tree since dsi-controller.yaml wants that name.