2021-12-15 22:56:56

by Rob Herring (Arm)

Subject: [PATCH] usb: chipidea: Set the DT node on the child device

The ChipIdea glue drivers just copy the glue resources to the "ci_hdrc"
child device. Instead, set the child device's DT node pointer to the
parent device's node so that platform_get_irq() can find the IRQ
resources in the DT. This removes the need for statically populating the
IRQ resources from the DT which has been deprecated for some time.

Signed-off-by: Rob Herring <[email protected]>
---
drivers/usb/chipidea/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index a56f06368d14..5359b2a2e4d2 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -864,6 +864,7 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
}

pdev->dev.parent = dev;
+ device_set_of_node_from_dev(&pdev->dev, dev);

ret = platform_device_add_resources(pdev, res, nres);
if (ret)
--
2.32.0

2021-12-16 14:12:35

by Peter Chen

Subject: Re: [PATCH] usb: chipidea: Set the DT node on the child device

On 21-12-15 16:56:46, Rob Herring wrote:
> The ChipIdea glue drivers just copy the glue resources to the "ci_hdrc"
> child device. Instead, set the child device's DT node pointer to the
> parent device's node so that platform_get_irq() can find the IRQ
> resources in the DT. This removes the need for statically populating the
> IRQ resources from the DT which has been deprecated for some time.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Peter Chen <[email protected]>

> ---
> drivers/usb/chipidea/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index a56f06368d14..5359b2a2e4d2 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -864,6 +864,7 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
> }
>
> pdev->dev.parent = dev;
> + device_set_of_node_from_dev(&pdev->dev, dev);
>
> ret = platform_device_add_resources(pdev, res, nres);
> if (ret)
> --
> 2.32.0
>

--

Thanks,
Peter Chen