2021-12-24 19:25:52

by David Heidelberg

Subject: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names

We don't care in which order are "rx" and "tx" DMA names supplied.

Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")

Signed-off-by: David Heidelberg <[email protected]>
---
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index f0a44b2cfa79..a4f74bec68a3 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -70,9 +70,13 @@ properties:
maxItems: 2

dma-names:
- items:
- - const: rx
- - const: tx
+ oneOf:
+ - items:
+ - const: tx
+ - const: rx
+ - items:
+ - const: rx
+ - const: tx

power-domains: true

--
2.34.1

2021-12-26 03:32:09

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names

On Fri, Dec 24, 2021 at 8:25 PM David Heidelberg <[email protected]> wrote:

> We don't care in which order are "rx" and "tx" DMA names supplied.
>
> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>
> Signed-off-by: David Heidelberg <[email protected]>

Good catch!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-12-28 16:58:41

by Ulf Hansson

Subject: Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names

On Fri, 24 Dec 2021 at 20:25, David Heidelberg <[email protected]> wrote:
>
> We don't care in which order are "rx" and "tx" DMA names supplied.
>
> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>
> Signed-off-by: David Heidelberg <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index f0a44b2cfa79..a4f74bec68a3 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -70,9 +70,13 @@ properties:
> maxItems: 2
>
> dma-names:
> - items:
> - - const: rx
> - - const: tx
> + oneOf:
> + - items:
> + - const: tx
> + - const: rx
> + - items:
> + - const: rx
> + - const: tx
>
> power-domains: true
>
> --
> 2.34.1
>

2022-01-04 18:53:30

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names

On Fri, Dec 24, 2021 at 08:25:45PM +0100, David Heidelberg wrote:
> We don't care in which order are "rx" and "tx" DMA names supplied.
>

I do. Other than avoiding dts changes, why do we need undefined order
here?

> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>

Drop the blank line.

> Signed-off-by: David Heidelberg <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index f0a44b2cfa79..a4f74bec68a3 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -70,9 +70,13 @@ properties:
> maxItems: 2
>
> dma-names:
> - items:
> - - const: rx
> - - const: tx
> + oneOf:
> + - items:
> + - const: tx
> + - const: rx
> + - items:
> + - const: rx
> + - const: tx

For future reference, the concise way to express this is:

maxItems: 2
items:
enum: [ rx, tx ]

>
> power-domains: true
>
> --
> 2.34.1
>
>