2022-01-13 03:17:09

by Menglong Dong

Subject: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

From: Menglong Dong <[email protected]>

'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
used, just remove them.

Signed-off-by: Menglong Dong <[email protected]>
---
tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
index 95d5b941bc1f..c9abfe3a11af 100644
--- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
+++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
@@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
{
void *data_end = (void *)(long) skb->data_end;
void *data = (void *)(long) skb->data;
- __u32 lport = skb->local_port;
- __u32 rport = skb->remote_port;
__u8 *d = data;
int err;

--
2.34.1

2022-01-13 17:07:50

by Song Liu

Subject: Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

On Wed, Jan 12, 2022 at 7:17 PM <[email protected]> wrote:
>
> From: Menglong Dong <[email protected]>
>
> 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
> used, just remove them.
>
> Signed-off-by: Menglong Dong <[email protected]>

Acked-by: Song Liu <[email protected]>

> ---
> tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> index 95d5b941bc1f..c9abfe3a11af 100644
> --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> @@ -7,8 +7,6 @@ int bpf_prog1(struct __sk_buff *skb)
> {
> void *data_end = (void *)(long) skb->data_end;
> void *data = (void *)(long) skb->data;
> - __u32 lport = skb->local_port;
> - __u32 rport = skb->remote_port;
> __u8 *d = data;
> int err;
>
> --
> 2.34.1
>

2022-01-15 15:47:49

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <[email protected]>:

On Thu, 13 Jan 2022 11:16:58 +0800 you wrote:
> From: Menglong Dong <[email protected]>
>
> 'lport' and 'rport' in bpf_prog1() of sockmap_verdict_prog.c is not
> used, just remove them.
>
> Signed-off-by: Menglong Dong <[email protected]>
>
> [...]

Here is the summary with links:
- [bpf-next] test: selftests: remove unused various in sockmap_verdict_prog.c
https://git.kernel.org/bpf/bpf-next/c/e80f2a0d1946

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html