2022-01-14 06:51:35

by Miaoqian Lin

Subject: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;

Fix the check of return value to catch errors correctly.

Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/gpio/gpio-idt3243x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
index 50003ad2e589..08493b05be2d 100644
--- a/drivers/gpio/gpio-idt3243x.c
+++ b/drivers/gpio/gpio-idt3243x.c
@@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
return PTR_ERR(ctrl->pic);

parent_irq = platform_get_irq(pdev, 0);
- if (!parent_irq)
- return -EINVAL;
+ if (parent_irq < 0)
+ return parent_irq;

girq = &ctrl->gc.irq;
girq->chip = &idt_gpio_irqchip;
--
2.17.1

2022-01-17 06:55:11

by Linus Walleij

Subject: Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe

On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <[email protected]> wrote:

> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
> Signed-off-by: Miaoqian Lin <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2022-01-18 02:27:02

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe

On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <[email protected]> wrote:
>
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/gpio/gpio-idt3243x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
> index 50003ad2e589..08493b05be2d 100644
> --- a/drivers/gpio/gpio-idt3243x.c
> +++ b/drivers/gpio/gpio-idt3243x.c
> @@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
> return PTR_ERR(ctrl->pic);
>
> parent_irq = platform_get_irq(pdev, 0);
> - if (!parent_irq)
> - return -EINVAL;
> + if (parent_irq < 0)
> + return parent_irq;
>
> girq = &ctrl->gc.irq;
> girq->chip = &idt_gpio_irqchip;
> --
> 2.17.1
>

Queued for fixes, thanks!

Bart