2022-01-14 23:05:23

by Michael S. Tsirkin

Subject: [PATCH] virtio: unexport virtio_finalize_features

virtio_finalize_features is only used internally within virtio.
No reason to export it.

Signed-off-by: Michael S. Tsirkin <[email protected]>
---
drivers/virtio/virtio.c | 3 +--
include/linux/virtio.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 00ac9db792a4..d891b0a354b0 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -166,7 +166,7 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status)
}
EXPORT_SYMBOL_GPL(virtio_add_status);

-int virtio_finalize_features(struct virtio_device *dev)
+static int virtio_finalize_features(struct virtio_device *dev)
{
int ret = dev->config->finalize_features(dev);
unsigned status;
@@ -202,7 +202,6 @@ int virtio_finalize_features(struct virtio_device *dev)
}
return 0;
}
-EXPORT_SYMBOL_GPL(virtio_finalize_features);

void virtio_reset_device(struct virtio_device *dev)
{
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 72292a62cd90..5464f398912a 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -133,7 +133,6 @@ bool is_virtio_device(struct device *dev);
void virtio_break_device(struct virtio_device *dev);

void virtio_config_changed(struct virtio_device *dev);
-int virtio_finalize_features(struct virtio_device *dev);
#ifdef CONFIG_PM_SLEEP
int virtio_device_freeze(struct virtio_device *dev);
int virtio_device_restore(struct virtio_device *dev);
--
MST

2022-01-17 14:31:32

by Jason Wang

Subject: Re: [PATCH] virtio: unexport virtio_finalize_features

在 2022/1/15 上午3:57, Michael S. Tsirkin 写道:
> virtio_finalize_features is only used internally within virtio.
> No reason to export it.
>
> Signed-off-by: Michael S. Tsirkin <[email protected]>


Acked-by: Jason Wang <[email protected]>


> ---
> drivers/virtio/virtio.c | 3 +--
> include/linux/virtio.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index 00ac9db792a4..d891b0a354b0 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -166,7 +166,7 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status)
> }
> EXPORT_SYMBOL_GPL(virtio_add_status);
>
> -int virtio_finalize_features(struct virtio_device *dev)
> +static int virtio_finalize_features(struct virtio_device *dev)
> {
> int ret = dev->config->finalize_features(dev);
> unsigned status;
> @@ -202,7 +202,6 @@ int virtio_finalize_features(struct virtio_device *dev)
> }
> return 0;
> }
> -EXPORT_SYMBOL_GPL(virtio_finalize_features);
>
> void virtio_reset_device(struct virtio_device *dev)
> {
> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index 72292a62cd90..5464f398912a 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -133,7 +133,6 @@ bool is_virtio_device(struct device *dev);
> void virtio_break_device(struct virtio_device *dev);
>
> void virtio_config_changed(struct virtio_device *dev);
> -int virtio_finalize_features(struct virtio_device *dev);
> #ifdef CONFIG_PM_SLEEP
> int virtio_device_freeze(struct virtio_device *dev);
> int virtio_device_restore(struct virtio_device *dev);

2022-01-18 02:23:09

by Cornelia Huck

Subject: Re: [PATCH] virtio: unexport virtio_finalize_features

On Fri, Jan 14 2022, "Michael S. Tsirkin" <[email protected]> wrote:

> virtio_finalize_features is only used internally within virtio.
> No reason to export it.
>
> Signed-off-by: Michael S. Tsirkin <[email protected]>
> ---
> drivers/virtio/virtio.c | 3 +--
> include/linux/virtio.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>

And nobody else really should use it.

Reviewed-by: Cornelia Huck <[email protected]>