LinuxLists.cc - [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings.

2022-01-17 17:00:08

Subject: [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings.

Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")
Signed-off-by: Slark Xiao <[email protected]>

---
v2: Add Fixes tag
---
drivers/bus/mhi/pci_generic.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 3a258a677df8..74e8fc342cfd 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
.config = &modem_foxconn_sdx55_config,
.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
.dma_data_width = 32,
+ .mru_default = 32768,
.sideband_wake = false,
};

--
2.25.1

2022-01-17 17:02:13

by Manivannan Sadhasivam

[permalink] [raw]

Subject: Re: [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings.

On Mon, Jan 17, 2022 at 04:16:44PM +0800, Slark Xiao wrote:
> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")

You have messed up the patch subject, please fix it. Also, the correct fixes tag
should be the one added the Foxconn modem support, precisely "aac426562f56".

One more thing, please make sure this MRU value works well for other Foxconn
modems supported by this config.

> Signed-off-by: Slark Xiao <[email protected]>

You should have added my Reviewed-by tag too...

Thanks,
Mani

>
> ---
> v2: Add Fixes tag
> ---
> drivers/bus/mhi/pci_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 3a258a677df8..74e8fc342cfd 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
> .config = &modem_foxconn_sdx55_config,
> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> .dma_data_width = 32,
> + .mru_default = 32768,
> .sideband_wake = false,
> };
>
> --
> 2.25.1
>

2022-01-17 17:07:07

by Slark Xiao

[permalink] [raw]

Subject: Re:Re: [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings.

At 2022-01-17 16:44:32, "Manivannan Sadhasivam" <[email protected]> wrote:
>On Mon, Jan 17, 2022 at 04:16:44PM +0800, Slark Xiao wrote:
>> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")
>
>You have messed up the patch subject, please fix it. Also, the correct fixes tag
>should be the one added the Foxconn modem support, precisely "aac426562f56".
>
Yes, sorry for this mistake.
>One more thing, please make sure this MRU value works well for other Foxconn
>modems supported by this config.
>
I am sure this would work for all our device. BTW, I want to add this mru_default to
cinterion-mv31 PRODUCT. Shall I use v3 or create a new version for that? It's confirmed
that this change could help fix issue on that product.
>> Signed-off-by: Slark Xiao <[email protected]>
>
>You should have added my Reviewed-by tag too...
Shall I add reviewd-by tag if I add changes on MV31 product?
>
>Thanks,
>Mani
>
>>
>> ---
>> v2: Add Fixes tag
>> ---
>> drivers/bus/mhi/pci_generic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
>> index 3a258a677df8..74e8fc342cfd 100644
>> --- a/drivers/bus/mhi/pci_generic.c
>> +++ b/drivers/bus/mhi/pci_generic.c
>> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
>> .config = &modem_foxconn_sdx55_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> .dma_data_width = 32,
>> + .mru_default = 32768,
>> .sideband_wake = false,
>> };
>>
>> --
>> 2.25.1
>>

2022-01-18 02:36:44

by Manivannan Sadhasivam

[permalink] [raw]

Subject: Re: Re: [PATCH net v2] For default mechanism, product would use default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a known issue which MRU 3500 would lead to data connection lost. So we align it with Qualcomm default MRU settings.

On Mon, Jan 17, 2022 at 05:54:37PM +0800, Slark Xiao wrote:
>
>
>
>
>
>
> At 2022-01-17 16:44:32, "Manivannan Sadhasivam" <[email protected]> wrote:
> >On Mon, Jan 17, 2022 at 04:16:44PM +0800, Slark Xiao wrote:
> >> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")
> >
> >You have messed up the patch subject, please fix it. Also, the correct fixes tag
> >should be the one added the Foxconn modem support, precisely "aac426562f56".
> >
> Yes, sorry for this mistake.
> >One more thing, please make sure this MRU value works well for other Foxconn
> >modems supported by this config.
> >
> I am sure this would work for all our device. BTW, I want to add this mru_default to
> cinterion-mv31 PRODUCT. Shall I use v3 or create a new version for that? It's confirmed
> that this change could help fix issue on that product.

Please submit individual patches with Fixes tag each.

> >> Signed-off-by: Slark Xiao <[email protected]>
> >
> >You should have added my Reviewed-by tag too...
> Shall I add reviewd-by tag if I add changes on MV31 product?
> >

No, only to this patch since I haven't reviewed the MV31 patch.

Thanks,
Mani

> >Thanks,
> >Mani
> >
> >>
> >> ---
> >> v2: Add Fixes tag
> >> ---
> >> drivers/bus/mhi/pci_generic.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> >> index 3a258a677df8..74e8fc342cfd 100644
> >> --- a/drivers/bus/mhi/pci_generic.c
> >> +++ b/drivers/bus/mhi/pci_generic.c
> >> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
> >> .config = &modem_foxconn_sdx55_config,
> >> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> >> .dma_data_width = 32,
> >> + .mru_default = 32768,
> >> .sideband_wake = false,
> >> };
> >>
> >> --
> >> 2.25.1
> >>