2022-01-04 16:27:30

by Jiasheng Jiang

[permalink] [raw]
Subject: [PATCH v3] mtd: onenand: Check for error irq

For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.

Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
v3: Roll back to v1 commit message and correct the fixes tag.
v2: Change the commit message.
---
drivers/mtd/nand/onenand/generic.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/onenand/generic.c b/drivers/mtd/nand/onenand/generic.c
index 8b6f4da5d720..a4b8b65fe15f 100644
--- a/drivers/mtd/nand/onenand/generic.c
+++ b/drivers/mtd/nand/onenand/generic.c
@@ -53,7 +53,12 @@ static int generic_onenand_probe(struct platform_device *pdev)
}

info->onenand.mmcontrol = pdata ? pdata->mmcontrol : NULL;
- info->onenand.irq = platform_get_irq(pdev, 0);
+
+ err = platform_get_irq(pdev, 0);
+ if (err < 0)
+ goto out_iounmap;
+
+ info->onenand.irq = err;

info->mtd.dev.parent = &pdev->dev;
info->mtd.priv = &info->onenand;
--
2.25.1



2022-01-24 10:05:02

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH v3] mtd: onenand: Check for error irq

Hi Jiasheng,

[email protected] wrote on Wed, 5 Jan 2022 00:26:58 +0800:

> For the possible failure of the platform_get_irq(), the returned irq
> could be error number and will finally cause the failure of the
> request_irq().
> Consider that platform_get_irq() can now in certain cases return
> -EPROBE_DEFER, and the consequences of letting request_irq() effectively
> convert that into -EINVAL, even at probe time rather than later on.
> So it might be better to check just now.
>
> Fixes: 2c22120fbd01 ("MTD: OneNAND: interrupt based wait support")
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---

Applied to nand/next.

Thanks,
Miquèl