2021-12-16 11:56:07

by Andrej Picej

Subject: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly

From: Yunus Bas <[email protected]>

The proper way to handle partly used MFD devices are to describe all MFD
subdevices in the devicetree and disable the not used ones. This
suppresses any warnings that may arise as a result.

Signed-off-by: Yunus Bas <[email protected]>
Signed-off-by: Andrej Picej <[email protected]>
---
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
2 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index 2ec154756bbc..3590f439adf5 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -213,6 +213,11 @@ pmic_rtc: rtc {
da9063_wdog: wdt {
compatible = "dlg,da9063-watchdog";
};
+
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ status = "disabled";
+ };
};
};

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 94b254bfd054..28a805384668 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -116,6 +116,16 @@ watchdog {
dlg,use-sw-pm;
};

+ thermal {
+ compatible = "dlg,da9062-thermal";
+ status = "disabled";
+ };
+
+ gpio {
+ compatible = "dlg,da9062-gpio";
+ status = "disabled";
+ };
+
regulators {
vdd_arm: buck1 {
regulator-name = "vdd_arm";
--
2.25.1

2022-01-26 20:44:45

by Shawn Guo

Subject: Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly

On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
> From: Yunus Bas <[email protected]>
>
> The proper way to handle partly used MFD devices are to describe all MFD
> subdevices in the devicetree and disable the not used ones. This
> suppresses any warnings that may arise as a result.
>
> Signed-off-by: Yunus Bas <[email protected]>
> Signed-off-by: Andrej Picej <[email protected]>

Use subject prefix like

ARM: dts: imx6qdl-phytec: ...

Shawn

> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 2ec154756bbc..3590f439adf5 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
> da9063_wdog: wdt {
> compatible = "dlg,da9063-watchdog";
> };
> +
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + status = "disabled";
> + };
> };
> };
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 94b254bfd054..28a805384668 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -116,6 +116,16 @@ watchdog {
> dlg,use-sw-pm;
> };
>
> + thermal {
> + compatible = "dlg,da9062-thermal";
> + status = "disabled";
> + };
> +
> + gpio {
> + compatible = "dlg,da9062-gpio";
> + status = "disabled";
> + };
> +
> regulators {
> vdd_arm: buck1 {
> regulator-name = "vdd_arm";
> --
> 2.25.1
>

2022-01-27 12:42:43

by Andrej Picej

Subject: Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly

On 26. 01. 22 10:27, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
>> From: Yunus Bas <[email protected]>
>>
>> The proper way to handle partly used MFD devices are to describe all MFD
>> subdevices in the devicetree and disable the not used ones. This
>> suppresses any warnings that may arise as a result.
>>
>> Signed-off-by: Yunus Bas <[email protected]>
>> Signed-off-by: Andrej Picej <[email protected]>
>
> Use subject prefix like
>
> ARM: dts: imx6qdl-phytec: ...
>
> Shawn

Will send a v2 with this change.

Thanks.

Andrej

>
>> ---
>> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
>> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index 2ec154756bbc..3590f439adf5 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
>> da9063_wdog: wdt {
>> compatible = "dlg,da9063-watchdog";
>> };
>> +
>> + onkey {
>> + compatible = "dlg,da9063-onkey";
>> + status = "disabled";
>> + };
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 94b254bfd054..28a805384668 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -116,6 +116,16 @@ watchdog {
>> dlg,use-sw-pm;
>> };
>>
>> + thermal {
>> + compatible = "dlg,da9062-thermal";
>> + status = "disabled";
>> + };
>> +
>> + gpio {
>> + compatible = "dlg,da9062-gpio";
>> + status = "disabled";
>> + };
>> +
>> regulators {
>> vdd_arm: buck1 {
>> regulator-name = "vdd_arm";
>> --
>> 2.25.1
>>