2022-02-08 01:50:00

by Stephen Hemminger

[permalink] [raw]
Subject: Re: [PATCH net-next 1/4] net: bridge: Add support for bridge port in locked mode

On Mon, 7 Feb 2022 11:07:39 +0100
Hans Schultz <[email protected]> wrote:

> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -532,6 +532,7 @@ enum {
> IFLA_BRPORT_GROUP_FWD_MASK,
> IFLA_BRPORT_NEIGH_SUPPRESS,
> IFLA_BRPORT_ISOLATED,
> + IFLA_BRPORT_LOCKED,
> IFLA_BRPORT_BACKUP_PORT,
> IFLA_BRPORT_MRP_RING_OPEN,

Adding new element in middle of enum causes them to be renumbered.
That breaks the kernel ABI. Please add only at end.