2022-02-08 15:49:59

by Amit Kumar Mahapatra

Subject: [PATCH] mtd: rawnand: pl353: Set the nand chip node as the flash node

In devicetree the flash information is embedded within nand chip node,
so during nand chip initialization the nand chip node should be passed
to nand_set_flash_node() api, instead of nand controller node.

Signed-off-by: Amit Kumar Mahapatra <[email protected]>
---
BRANCH: nand/next
---
drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
index 8a91e069ee2e..3c6f6aff649f 100644
--- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
+++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
@@ -1062,7 +1062,7 @@ static int pl35x_nand_chip_init(struct pl35x_nandc *nfc,
chip->controller = &nfc->controller;
mtd = nand_to_mtd(chip);
mtd->dev.parent = nfc->dev;
- nand_set_flash_node(chip, nfc->dev->of_node);
+ nand_set_flash_node(chip, np);
if (!mtd->name) {
mtd->name = devm_kasprintf(nfc->dev, GFP_KERNEL,
"%s", PL35X_NANDC_DRIVER_NAME);
--
2.17.1

2022-02-09 11:33:49

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: pl353: Set the nand chip node as the flash node

Hi Amit,

[email protected] wrote on Tue, 8 Feb 2022 18:27:38 +0530:

> In devicetree the flash information is embedded within nand chip node,
> so during nand chip initialization the nand chip node should be passed
> to nand_set_flash_node() api, instead of nand controller node.
>
> Signed-off-by: Amit Kumar Mahapatra <[email protected]>

Can you please add Fixes tag?

> ---
> BRANCH: nand/next
> ---
> drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> index 8a91e069ee2e..3c6f6aff649f 100644
> --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c
> +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c
> @@ -1062,7 +1062,7 @@ static int pl35x_nand_chip_init(struct pl35x_nandc *nfc,
> chip->controller = &nfc->controller;
> mtd = nand_to_mtd(chip);
> mtd->dev.parent = nfc->dev;
> - nand_set_flash_node(chip, nfc->dev->of_node);
> + nand_set_flash_node(chip, np);
> if (!mtd->name) {
> mtd->name = devm_kasprintf(nfc->dev, GFP_KERNEL,
> "%s", PL35X_NANDC_DRIVER_NAME);

yup, that was wrong.

Thanks,
Miquèl