2022-02-10 09:02:43

by Gatis Peisenieks

Subject: [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC

If NIC had packets in tx queue at the moment link down event
happened, it could result in tx timeout when link got back up.

Since device has more than one tx queue we need to reset them
accordingly.

Signed-off-by: Gatis Peisenieks <[email protected]>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index da595242bc13..f50604f3e541 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -900,7 +900,7 @@ static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter,
atl1c_clean_buffer(pdev, buffer_info);
}

- netdev_reset_queue(adapter->netdev);
+ netdev_tx_reset_queue(netdev_get_tx_queue(adapter->netdev, queue));

/* Zero out Tx-buffers */
memset(tpd_ring->desc, 0, sizeof(struct atl1c_tpd_desc) *
--
2.31.1

2022-02-11 03:07:41

by Jakub Kicinski

Subject: Re: [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC

On Thu, 10 Feb 2022 10:12:01 +0200 Gatis Peisenieks wrote:
> If NIC had packets in tx queue at the moment link down event
> happened, it could result in tx timeout when link got back up.
>
> Since device has more than one tx queue we need to reset them
> accordingly.
>
> Signed-off-by: Gatis Peisenieks <[email protected]>

Fixes: 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC")

?