2022-02-11 08:50:10

by Frank Rowand

Subject: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level

From: Frank Rowand <[email protected]>

Printing the devicetree unittest pass message for each passed test
creates much console verbosity. The existing pass messages are
printed at loglevel KERN_DEBUG so they will not print by default.

Change default to print the pass messages at loglevel PR_INFO so
they will print with the default console loglevel.

The test community expects either a pass or a fail message for each
test in a test suite. The messages are typically post-processed to
report pass/fail results.

Signed-off-by: Frank Rowand <[email protected]>
---

One review comment to similar previous patch "of: unittest: print
pass message as same lovlevel as fail" suggested to also change
the text of the pass message to include "PASS" instead of "pass".
I would rather leave the text unchanged to minimize churn for any
existing users of the message. It is my intention to change the
pass and fail messages to KTAP version 2 format as soon as that
version of the specification is completed.

drivers/of/unittest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 70992103c07d..9012e6900965 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -44,7 +44,7 @@ static struct unittest_results {
pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \
} else { \
unittest_results.passed++; \
- pr_debug("pass %s():%i\n", __func__, __LINE__); \
+ pr_info("pass %s():%i\n", __func__, __LINE__); \
} \
failed; \
})
--
Frank Rowand <[email protected]>

2022-02-11 12:11:17

by Naresh Kamboju

Subject: Re: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level

On Fri, 11 Feb 2022 at 04:38, <[email protected]> wrote:
>
> From: Frank Rowand <[email protected]>
>
> Printing the devicetree unittest pass message for each passed test
> creates much console verbosity. The existing pass messages are
> printed at loglevel KERN_DEBUG so they will not print by default.
>
> Change default to print the pass messages at loglevel PR_INFO so
> they will print with the default console loglevel.
>
> The test community expects either a pass or a fail message for each
> test in a test suite. The messages are typically post-processed to
> report pass/fail results.
>
> Signed-off-by: Frank Rowand <[email protected]>

Tested-by: Linux Kernel Functional Testing <[email protected]>

Test log link,
https://lkft.validation.linaro.org/scheduler/job/4529628#L1697

> ---
>
> One review comment to similar previous patch "of: unittest: print
> pass message as same lovlevel as fail" suggested to also change
> the text of the pass message to include "PASS" instead of "pass".
> I would rather leave the text unchanged to minimize churn for any
> existing users of the message. It is my intention to change the
> pass and fail messages to KTAP version 2 format as soon as that
> version of the specification is completed.
>
> drivers/of/unittest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 70992103c07d..9012e6900965 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -44,7 +44,7 @@ static struct unittest_results {
> pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \
> } else { \
> unittest_results.passed++; \
> - pr_debug("pass %s():%i\n", __func__, __LINE__); \
> + pr_info("pass %s():%i\n", __func__, __LINE__); \
> } \
> failed; \
> })
> --
> Frank Rowand <[email protected]>


--
Linaro LKFT
https://lkft.linaro.org

2022-02-15 22:56:23

by Rob Herring (Arm)

Subject: Re: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level

On Thu, 10 Feb 2022 17:08:19 -0600, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> Printing the devicetree unittest pass message for each passed test
> creates much console verbosity. The existing pass messages are
> printed at loglevel KERN_DEBUG so they will not print by default.
>
> Change default to print the pass messages at loglevel PR_INFO so
> they will print with the default console loglevel.
>
> The test community expects either a pass or a fail message for each
> test in a test suite. The messages are typically post-processed to
> report pass/fail results.
>
> Signed-off-by: Frank Rowand <[email protected]>
> ---
>
> One review comment to similar previous patch "of: unittest: print
> pass message as same lovlevel as fail" suggested to also change
> the text of the pass message to include "PASS" instead of "pass".
> I would rather leave the text unchanged to minimize churn for any
> existing users of the message. It is my intention to change the
> pass and fail messages to KTAP version 2 format as soon as that
> version of the specification is completed.
>
> drivers/of/unittest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!