Hi,
Changes since v1:
1. Add tags.
2. Adjust subject (Uwe).
Best regards,
Krzysztof
Krzysztof Kozlowski (15):
dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
dt-bindings: pwm: imx: Include generic pwm schema
dt-bindings: pwm: intel,lgm: Include generic pwm schema
dt-bindings: pwm: iqs620a: Include generic pwm schema
dt-bindings: pwm: mxs: Include generic pwm schema
dt-bindings: pwm: rockchip: Include generic pwm schema
dt-bindings: pwm: sifive: Include generic pwm schema
dt-bindings: pwm: renesas,pwm: Include generic pwm schema
dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
dt-bindings: pwm: samsung: Do not require pwm-cells twice
dt-bindings: pwm: tiecap: Do not require pwm-cells twice
dt-bindings: pwm: tiehrpwm: Do not require pwm-cells twice
dt-bindings: pwm: renesas,tpu: Do not require pwm-cells twice
.../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 53 ++++++-------
.../bindings/pwm/brcm,bcm7038-pwm.yaml | 1 -
.../devicetree/bindings/pwm/imx-pwm.yaml | 4 +-
.../devicetree/bindings/pwm/imx-tpm-pwm.yaml | 4 +-
.../bindings/pwm/intel,keembay-pwm.yaml | 1 -
.../bindings/pwm/intel,lgm-pwm.yaml | 3 +
.../devicetree/bindings/pwm/iqs620a-pwm.yaml | 4 +-
.../devicetree/bindings/pwm/mxs-pwm.yaml | 4 +-
.../devicetree/bindings/pwm/pwm-rockchip.yaml | 74 ++++++++++---------
.../devicetree/bindings/pwm/pwm-samsung.yaml | 1 -
.../devicetree/bindings/pwm/pwm-sifive.yaml | 4 +-
.../devicetree/bindings/pwm/pwm-tiecap.yaml | 1 -
.../devicetree/bindings/pwm/pwm-tiehrpwm.yaml | 1 -
.../bindings/pwm/renesas,pwm-rcar.yaml | 26 ++++---
.../bindings/pwm/renesas,tpu-pwm.yaml | 1 -
.../bindings/pwm/toshiba,pwm-visconti.yaml | 4 +-
16 files changed, 101 insertions(+), 85 deletions(-)
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/mxs-pwm.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml b/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
index 8740e076061e..a34cbc13f691 100644
--- a/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
@@ -10,6 +10,9 @@ maintainers:
- Shawn Guo <[email protected]>
- Anson Huang <[email protected]>
+allOf:
+ - $ref: pwm.yaml#
+
properties:
compatible:
enum:
@@ -28,7 +31,6 @@ properties:
required:
- compatible
- reg
- - "#pwm-cells"
- fsl,pwm-number
additionalProperties: false
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 4 +++-
Documentation/devicetree/bindings/pwm/imx-tpm-pwm.yaml | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
index 379d693889f6..b3da4e629341 100644
--- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
@@ -9,6 +9,9 @@ title: Freescale i.MX PWM controller
maintainers:
- Philipp Zabel <[email protected]>
+allOf:
+ - $ref: pwm.yaml#
+
properties:
"#pwm-cells":
description: |
@@ -59,7 +62,6 @@ properties:
maxItems: 1
required:
- - "#pwm-cells"
- compatible
- reg
- clocks
diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.yaml
index fe9ef42544f1..8bef9dfeba9a 100644
--- a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.yaml
@@ -13,6 +13,9 @@ description: |
The TPM counter and period counter are shared between multiple
channels, so all channels should use same period setting.
+allOf:
+ - $ref: pwm.yaml#
+
properties:
"#pwm-cells":
const: 3
@@ -34,7 +37,6 @@ properties:
maxItems: 1
required:
- - "#pwm-cells"
- compatible
- reg
- clocks
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/pwm-sifive.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
index 84e66913d042..676b2160bada 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
@@ -22,6 +22,9 @@ description:
https://github.com/sifive/sifive-blocks/tree/master/src/main/scala/devices/pwm
+allOf:
+ - $ref: pwm.yaml#
+
properties:
compatible:
items:
@@ -55,7 +58,6 @@ required:
- compatible
- reg
- clocks
- - "#pwm-cells"
- interrupts
additionalProperties: false
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml b/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
index 1d7c27be50da..0a46af240d83 100644
--- a/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
@@ -15,6 +15,9 @@ description: |
Documentation/devicetree/bindings/mfd/iqs62x.yaml for further details as
well as an example.
+allOf:
+ - $ref: pwm.yaml#
+
properties:
compatible:
enum:
@@ -25,7 +28,6 @@ properties:
required:
- compatible
- - "#pwm-cells"
additionalProperties: false
--
2.32.0
pwm-cells property is already required by pwm.yaml schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
index 4080e098f746..119de3d7f9dd 100644
--- a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
@@ -28,7 +28,6 @@ properties:
required:
- compatible
- reg
- - "#pwm-cells"
- clocks
additionalProperties: false
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Heiko Stuebner <[email protected]>
---
.../devicetree/bindings/pwm/pwm-rockchip.yaml | 74 ++++++++++---------
1 file changed, 38 insertions(+), 36 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
index 81a54a4e8e3e..a336ff9364a9 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
@@ -51,42 +51,44 @@ properties:
required:
- compatible
- reg
- - "#pwm-cells"
-
-if:
- properties:
- compatible:
- contains:
- enum:
- - rockchip,rk3328-pwm
- - rockchip,rv1108-pwm
-
-then:
- properties:
- clocks:
- items:
- - description: Used to derive the functional clock for the device.
- - description: Used as the APB bus clock.
-
- clock-names:
- items:
- - const: pwm
- - const: pclk
-
- required:
- - clocks
- - clock-names
-
-else:
- properties:
- clocks:
- maxItems: 1
- description:
- Used both to derive the functional clock
- for the device and as the bus clock.
-
- required:
- - clocks
+
+allOf:
+ - $ref: pwm.yaml#
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3328-pwm
+ - rockchip,rv1108-pwm
+
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Used to derive the functional clock for the device.
+ - description: Used as the APB bus clock.
+
+ clock-names:
+ items:
+ - const: pwm
+ - const: pclk
+
+ required:
+ - clocks
+ - clock-names
+
+ else:
+ properties:
+ clocks:
+ maxItems: 1
+ description:
+ Used both to derive the functional clock
+ for the device and as the bus clock.
+
+ required:
+ - clocks
additionalProperties: false
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Jernej Skrabec <[email protected]>
---
.../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 53 ++++++++++---------
1 file changed, 28 insertions(+), 25 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
index 800d511502c4..e93e935564fb 100644
--- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
@@ -52,33 +52,36 @@ properties:
resets:
maxItems: 1
-if:
- properties:
- compatible:
- contains:
- const: allwinner,sun50i-h6-pwm
-
-then:
- properties:
- clocks:
- maxItems: 2
-
- clock-names:
- items:
- - const: mod
- - const: bus
-
- required:
- - clock-names
- - resets
-
-else:
- properties:
- clocks:
- maxItems: 1
+
+allOf:
+ - $ref: pwm.yaml#
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: allwinner,sun50i-h6-pwm
+
+ then:
+ properties:
+ clocks:
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: mod
+ - const: bus
+
+ required:
+ - clock-names
+ - resets
+
+ else:
+ properties:
+ clocks:
+ maxItems: 1
required:
- - "#pwm-cells"
- compatible
- reg
- clocks
--
2.32.0
pwm-cells property is already required by pwm.yaml schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
index 188679cb8b8c..fe603fb1b2cc 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
@@ -86,7 +86,6 @@ required:
- clocks
- clock-names
- compatible
- - "#pwm-cells"
- reg
additionalProperties: false
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml b/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
index 11a606536169..59d7c4d864c1 100644
--- a/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
@@ -9,6 +9,9 @@ title: LGM SoC PWM fan controller
maintainers:
- Rahul Tanwar <[email protected]>
+allOf:
+ - $ref: pwm.yaml#
+
properties:
compatible:
const: intel,lgm-pwm
--
2.32.0
pwm-cells property is already required by pwm.yaml schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml b/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
index ed35b6cc48d5..3840ae709bc6 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
@@ -47,7 +47,6 @@ properties:
required:
- compatible
- reg
- - "#pwm-cells"
- clocks
- clock-names
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Nobuhiro Iwamatsu <[email protected]>
---
.../devicetree/bindings/pwm/toshiba,pwm-visconti.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
index d350f5edfb67..46622661e5fb 100644
--- a/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
+++ b/Documentation/devicetree/bindings/pwm/toshiba,pwm-visconti.yaml
@@ -9,6 +9,9 @@ title: Toshiba Visconti PWM Controller
maintainers:
- Nobuhiro Iwamatsu <[email protected]>
+allOf:
+ - $ref: pwm.yaml#
+
properties:
compatible:
items:
@@ -23,7 +26,6 @@ properties:
required:
- compatible
- reg
- - '#pwm-cells'
additionalProperties: false
--
2.32.0
pwm-cells property is already required by pwm.yaml schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Vijayakannan Ayyathurai <[email protected]>
---
Documentation/devicetree/bindings/pwm/intel,keembay-pwm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/intel,keembay-pwm.yaml b/Documentation/devicetree/bindings/pwm/intel,keembay-pwm.yaml
index ff6880a02ce6..ec9f6bab798c 100644
--- a/Documentation/devicetree/bindings/pwm/intel,keembay-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/intel,keembay-pwm.yaml
@@ -31,7 +31,6 @@ required:
- compatible
- reg
- clocks
- - '#pwm-cells'
additionalProperties: false
--
2.32.0
pwm-cells property is already required by pwm.yaml schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
index ee312cb210e6..70a8f766212e 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
@@ -48,7 +48,6 @@ properties:
required:
- compatible
- reg
- - "#pwm-cells"
- clocks
- clock-names
--
2.32.0
pwm-cells property is already required by pwm.yaml schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
index 1f5c6384182e..c6b2ab56b7fe 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
@@ -68,7 +68,6 @@ properties:
required:
- compatible
- reg
- - '#pwm-cells'
- clocks
- power-domains
--
2.32.0
Include generic pwm.yaml schema, which enforces PWM node naming and
brings pwm-cells requirement.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pwm/renesas,pwm-rcar.yaml | 26 ++++++++++---------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.yaml b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.yaml
index 7ea1070b4b3a..1c94acbc2b4a 100644
--- a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.yaml
+++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.yaml
@@ -59,21 +59,23 @@ properties:
required:
- compatible
- reg
- - '#pwm-cells'
- clocks
- power-domains
-if:
- not:
- properties:
- compatible:
- contains:
- enum:
- - renesas,pwm-r8a7778
- - renesas,pwm-r8a7779
-then:
- required:
- - resets
+allOf:
+ - $ref: pwm.yaml#
+
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,pwm-r8a7778
+ - renesas,pwm-r8a7779
+ then:
+ required:
+ - resets
additionalProperties: false
--
2.32.0
Hi Krzysztof,
> From: Krzysztof Kozlowski, Sent: Tuesday, February 15, 2022 6:22 AM
> Subject: [PATCH v2 08/15] dt-bindings: pwm: renesas,pwm: Include generic pwm schema
>
> Include generic pwm.yaml schema, which enforces PWM node naming and
> brings pwm-cells requirement.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <[email protected]>
Best regards,
Yoshihiro Shimoda
On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
> On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König
> <[email protected]> wrote:
>>
>> Hello,
>>
>> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
>> my last mail]
>>
>> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>> Changes since v1:
>>> 1. Add tags.
>>> 2. Adjust subject (Uwe).
>>
>> However you only took a part of my suggestion ...
>>
>>> Krzysztof Kozlowski (15):
>>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
>>> dt-bindings: pwm: imx: Include generic pwm schema
>>> dt-bindings: pwm: intel,lgm: Include generic pwm schema
>>> dt-bindings: pwm: iqs620a: Include generic pwm schema
>>> dt-bindings: pwm: mxs: Include generic pwm schema
>>> dt-bindings: pwm: rockchip: Include generic pwm schema
>>> dt-bindings: pwm: sifive: Include generic pwm schema
>>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
>>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
>>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
>>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
>>
>> ... The actual patch has a space after the comma, I like this variant
>> without comma better as this is a compatible string.
>
> I am confused. My patch does not have comma after space. Your reply
> had such in the subject, but not in the proposed new subject you wrote
> in msg, so I left it as is. Without comma. If you still see comma, it
> is something with your mail client.
>
> See:
> https://lore.kernel.org/linux-devicetree/[email protected]/T/#u
>
> Also reply from Vijayakannan does not have comma:
> https://lore.kernel.org/linux-devicetree/[email protected]/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
>
>> Also a # before
>> pwm-cells would be nice.
>
> I can add this.
Just one more clarification - you proposed also to remove "pwm:"
middle-prefix. Shall I remove it from every patch and use instead full
file name?
Best regards,
Krzysztof
Hi Krzysztof,
On Mon, Feb 14, 2022 at 10:21:43PM +0100, Krzysztof Kozlowski wrote:
> Include generic pwm.yaml schema, which enforces PWM node naming and
> brings pwm-cells requirement.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml b/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
> index 1d7c27be50da..0a46af240d83 100644
> --- a/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/iqs620a-pwm.yaml
> @@ -15,6 +15,9 @@ description: |
> Documentation/devicetree/bindings/mfd/iqs62x.yaml for further details as
> well as an example.
>
> +allOf:
> + - $ref: pwm.yaml#
> +
> properties:
> compatible:
> enum:
> @@ -25,7 +28,6 @@ properties:
>
> required:
> - compatible
> - - "#pwm-cells"
>
> additionalProperties: false
>
> --
> 2.32.0
>
Acked-by: Jeff LaBundy <[email protected]>
Kind regards,
Jeff LaBundy
Hi Krzysztof,
> From: Krzysztof Kozlowski, Sent: Tuesday, February 15, 2022 6:22 AM
>
> pwm-cells property is already required by pwm.yaml schema.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <[email protected]>
Best regards,
Yoshihiro Shimoda
On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
> > On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-K?nig
> > <[email protected]> wrote:
> >>
> >> Hello,
> >>
> >> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
> >> my last mail]
> >>
> >> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> >>> Hi,
> >>>
> >>> Changes since v1:
> >>> 1. Add tags.
> >>> 2. Adjust subject (Uwe).
> >>
> >> However you only took a part of my suggestion ...
> >>
> >>> Krzysztof Kozlowski (15):
> >>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> >>> dt-bindings: pwm: imx: Include generic pwm schema
> >>> dt-bindings: pwm: intel,lgm: Include generic pwm schema
> >>> dt-bindings: pwm: iqs620a: Include generic pwm schema
> >>> dt-bindings: pwm: mxs: Include generic pwm schema
> >>> dt-bindings: pwm: rockchip: Include generic pwm schema
> >>> dt-bindings: pwm: sifive: Include generic pwm schema
> >>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> >>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> >>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> >>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
> >>
> >> ... The actual patch has a space after the comma, I like this variant
> >> without comma better as this is a compatible string.
> >
> > I am confused. My patch does not have comma after space. Your reply
> > had such in the subject, but not in the proposed new subject you wrote
> > in msg, so I left it as is. Without comma. If you still see comma, it
> > is something with your mail client.
> >
> > See:
> > https://lore.kernel.org/linux-devicetree/[email protected]/T/#u
> >
> > Also reply from Vijayakannan does not have comma:
> > https://lore.kernel.org/linux-devicetree/[email protected]/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
Strange: I have this mail four times in my mailboxes (via
linux-arm-kernel, linux-pwm, [email protected] and directly). In the
two latter the Subject line is broken in two:
Subject: [PATCH v2 08/15] dt-bindings: pwm: renesas,
pwm: Include generic pwm schema
So this is indeed a problem near my side.
> Just one more clarification - you proposed also to remove "pwm:"
> middle-prefix. Shall I remove it from every patch and use instead full
> file name?
I did that to save some vertical space in the Subject line. I don't feel
strong here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On Tue, Feb 15, 2022 at 10:41:06AM +0100, Uwe Kleine-K?nig wrote:
> On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote:
> > On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
> > > On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-K?nig
> > > <[email protected]> wrote:
> > >>
> > >> Hello,
> > >>
> > >> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
> > >> my last mail]
> > >>
> > >> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> > >>> Hi,
> > >>>
> > >>> Changes since v1:
> > >>> 1. Add tags.
> > >>> 2. Adjust subject (Uwe).
> > >>
> > >> However you only took a part of my suggestion ...
> > >>
> > >>> Krzysztof Kozlowski (15):
> > >>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> > >>> dt-bindings: pwm: imx: Include generic pwm schema
> > >>> dt-bindings: pwm: intel,lgm: Include generic pwm schema
> > >>> dt-bindings: pwm: iqs620a: Include generic pwm schema
> > >>> dt-bindings: pwm: mxs: Include generic pwm schema
> > >>> dt-bindings: pwm: rockchip: Include generic pwm schema
> > >>> dt-bindings: pwm: sifive: Include generic pwm schema
> > >>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> > >>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> > >>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> > >>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
> > >>
> > >> ... The actual patch has a space after the comma, I like this variant
> > >> without comma better as this is a compatible string.
> > >
> > > I am confused. My patch does not have comma after space. Your reply
> > > had such in the subject, but not in the proposed new subject you wrote
> > > in msg, so I left it as is. Without comma. If you still see comma, it
> > > is something with your mail client.
> > >
> > > See:
> > > https://lore.kernel.org/linux-devicetree/[email protected]/T/#u
> > >
> > > Also reply from Vijayakannan does not have comma:
> > > https://lore.kernel.org/linux-devicetree/[email protected]/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
>
> Strange: I have this mail four times in my mailboxes (via
> linux-arm-kernel, linux-pwm, [email protected] and directly). In the
> two latter the Subject line is broken in two:
I was wrong. The ones to [email protected] and the linux-arm-kernel
one are the ones with the linebreak.
Hmm,
http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717310.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717304.html
has the linebreaks, too. Still I wonder what is different between
[email protected] and [email protected].
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello,
[dropped Anson Huang and Yash Shah from Cc: which were not reachable for
my last mail]
On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v1:
> 1. Add tags.
> 2. Adjust subject (Uwe).
However you only took a part of my suggestion ...
> Krzysztof Kozlowski (15):
> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> dt-bindings: pwm: imx: Include generic pwm schema
> dt-bindings: pwm: intel,lgm: Include generic pwm schema
> dt-bindings: pwm: iqs620a: Include generic pwm schema
> dt-bindings: pwm: mxs: Include generic pwm schema
> dt-bindings: pwm: rockchip: Include generic pwm schema
> dt-bindings: pwm: sifive: Include generic pwm schema
> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
... The actual patch has a space after the comma, I like this variant
without comma better as this is a compatible string. Also a # before
pwm-cells would be nice.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König
<[email protected]> wrote:
>
> Hello,
>
> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
> my last mail]
>
> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > Changes since v1:
> > 1. Add tags.
> > 2. Adjust subject (Uwe).
>
> However you only took a part of my suggestion ...
>
> > Krzysztof Kozlowski (15):
> > dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> > dt-bindings: pwm: imx: Include generic pwm schema
> > dt-bindings: pwm: intel,lgm: Include generic pwm schema
> > dt-bindings: pwm: iqs620a: Include generic pwm schema
> > dt-bindings: pwm: mxs: Include generic pwm schema
> > dt-bindings: pwm: rockchip: Include generic pwm schema
> > dt-bindings: pwm: sifive: Include generic pwm schema
> > dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> > dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> > dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> > dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
>
> ... The actual patch has a space after the comma, I like this variant
> without comma better as this is a compatible string.
I am confused. My patch does not have comma after space. Your reply
had such in the subject, but not in the proposed new subject you wrote
in msg, so I left it as is. Without comma. If you still see comma, it
is something with your mail client.
See:
https://lore.kernel.org/linux-devicetree/[email protected]/T/#u
Also reply from Vijayakannan does not have comma:
https://lore.kernel.org/linux-devicetree/[email protected]/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
> Also a # before
> pwm-cells would be nice.
I can add this.
Best regards,
Krzysztof
On 15/02/2022 11:49, Uwe Kleine-König wrote:
> On Tue, Feb 15, 2022 at 10:41:06AM +0100, Uwe Kleine-König wrote:
>> On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote:
>>> On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
>>>> On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König
>>>> <[email protected]> wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
>>>>> my last mail]
>>>>>
>>>>> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Changes since v1:
>>>>>> 1. Add tags.
>>>>>> 2. Adjust subject (Uwe).
>>>>>
>>>>> However you only took a part of my suggestion ...
>>>>>
>>>>>> Krzysztof Kozlowski (15):
>>>>>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
>>>>>> dt-bindings: pwm: imx: Include generic pwm schema
>>>>>> dt-bindings: pwm: intel,lgm: Include generic pwm schema
>>>>>> dt-bindings: pwm: iqs620a: Include generic pwm schema
>>>>>> dt-bindings: pwm: mxs: Include generic pwm schema
>>>>>> dt-bindings: pwm: rockchip: Include generic pwm schema
>>>>>> dt-bindings: pwm: sifive: Include generic pwm schema
>>>>>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
>>>>>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
>>>>>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
>>>>>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
>>>>>
>>>>> ... The actual patch has a space after the comma, I like this variant
>>>>> without comma better as this is a compatible string.
>>>>
>>>> I am confused. My patch does not have comma after space. Your reply
>>>> had such in the subject, but not in the proposed new subject you wrote
>>>> in msg, so I left it as is. Without comma. If you still see comma, it
>>>> is something with your mail client.
>>>>
>>>> See:
>>>> https://lore.kernel.org/linux-devicetree/[email protected]/T/#u
>>>>
>>>> Also reply from Vijayakannan does not have comma:
>>>> https://lore.kernel.org/linux-devicetree/[email protected]/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
>>
>> Strange: I have this mail four times in my mailboxes (via
>> linux-arm-kernel, linux-pwm, [email protected] and directly). In the
>> two latter the Subject line is broken in two:
>
> I was wrong. The ones to [email protected] and the linux-arm-kernel
> one are the ones with the linebreak.
>
> Hmm,
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717310.html
> http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717304.html
>
> has the linebreaks, too. Still I wonder what is different between
> [email protected] and [email protected].
Other threads - not only mine - are also affected:
http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714311.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714316.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714364.html
Best regards,
Krzysztof
On Tue, Feb 15, 2022 at 01:41:20PM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2022 11:49, Uwe Kleine-K?nig wrote:
> > On Tue, Feb 15, 2022 at 10:41:06AM +0100, Uwe Kleine-K?nig wrote:
> >> On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote:
> >>> On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
> >>>> On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-K?nig
> >>>> <[email protected]> wrote:
> >>>>>
> >>>>> Hello,
> >>>>>
> >>>>> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
> >>>>> my last mail]
> >>>>>
> >>>>> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Changes since v1:
> >>>>>> 1. Add tags.
> >>>>>> 2. Adjust subject (Uwe).
> >>>>>
> >>>>> However you only took a part of my suggestion ...
> >>>>>
> >>>>>> Krzysztof Kozlowski (15):
> >>>>>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> >>>>>> dt-bindings: pwm: imx: Include generic pwm schema
> >>>>>> dt-bindings: pwm: intel,lgm: Include generic pwm schema
> >>>>>> dt-bindings: pwm: iqs620a: Include generic pwm schema
> >>>>>> dt-bindings: pwm: mxs: Include generic pwm schema
> >>>>>> dt-bindings: pwm: rockchip: Include generic pwm schema
> >>>>>> dt-bindings: pwm: sifive: Include generic pwm schema
> >>>>>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> >>>>>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> >>>>>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> >>>>>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
> >>>>>
> >>>>> ... The actual patch has a space after the comma, I like this variant
> >>>>> without comma better as this is a compatible string.
> >>>>
> >>>> I am confused. My patch does not have comma after space. Your reply
> >>>> had such in the subject, but not in the proposed new subject you wrote
> >>>> in msg, so I left it as is. Without comma. If you still see comma, it
> >>>> is something with your mail client.
> >>>>
> >>>> See:
> >>>> https://lore.kernel.org/linux-devicetree/[email protected]/T/#u
> >>>>
> >>>> Also reply from Vijayakannan does not have comma:
> >>>> https://lore.kernel.org/linux-devicetree/[email protected]/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
> >>
> >> Strange: I have this mail four times in my mailboxes (via
> >> linux-arm-kernel, linux-pwm, [email protected] and directly). In the
> >> two latter the Subject line is broken in two:
> >
> > I was wrong. The ones to [email protected] and the linux-arm-kernel
> > one are the ones with the linebreak.
> >
> > Hmm,
> >
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717310.html
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717304.html
> >
> > has the linebreaks, too. Still I wonder what is different between
> > [email protected] and [email protected].
>
> Other threads - not only mine - are also affected:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714311.html
> http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714316.html
> http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714364.html
In the meantime I'm confident that mailman2 is the culprit.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello,
On Tue, Feb 15, 2022 at 01:58:56PM +0100, Uwe Kleine-K?nig wrote:
> On Tue, Feb 15, 2022 at 01:41:20PM +0100, Krzysztof Kozlowski wrote:
> > On 15/02/2022 11:49, Uwe Kleine-K?nig wrote:
> > > [... Something inserted a space in Subject lines ...]
> >
> > Other threads - not only mine - are also affected:
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714311.html
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714316.html
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714364.html
>
> In the meantime I'm confident that mailman2 is the culprit.
For the record: Using python2 (which is what mailman2 uses):
>>> from email.header import Header
>>> h = Header('[PATCH v2 08/15] dt-bindings: pwm: renesas,pwm: Include generic pwm schema', maxlinelen=76, header_name='Subject')
>>> h.encode()
'[PATCH v2 08/15] dt-bindings: pwm: renesas,\n pwm: Include generic pwm schema'
This is the inner source of the problem, mailman just does something
like:
>>> import email
>>> a = email.message_from_file(open('message'))
>>> open('message-mangled', 'w').write(a.as_string())
So we just have to wait until all mailserver admins migrate away from
mailman2. I bet this will happen no later than when Python2 will become
EOL. :-\
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On Mon, Feb 14, 2022 at 3:22 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Hi,
>
> Changes since v1:
> 1. Add tags.
> 2. Adjust subject (Uwe).
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (15):
> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> dt-bindings: pwm: imx: Include generic pwm schema
> dt-bindings: pwm: intel,lgm: Include generic pwm schema
> dt-bindings: pwm: iqs620a: Include generic pwm schema
> dt-bindings: pwm: mxs: Include generic pwm schema
> dt-bindings: pwm: rockchip: Include generic pwm schema
> dt-bindings: pwm: sifive: Include generic pwm schema
> dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
> dt-bindings: pwm: samsung: Do not require pwm-cells twice
> dt-bindings: pwm: tiecap: Do not require pwm-cells twice
> dt-bindings: pwm: tiehrpwm: Do not require pwm-cells twice
> dt-bindings: pwm: renesas,tpu: Do not require pwm-cells twice
For the series:
Reviewed-by: Rob Herring <[email protected]>
On 14/02/2022 22:21, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v1:
> 1. Add tags.
> 2. Adjust subject (Uwe).
>
Hi Thierry, Uwe and Lee,
Any comments here? Rob acked all these, so these are clear to go via PWM
tree.
Best regards,
Krzysztof
Hello,
(dropped Anson Huang and Yash Shah from Cc, their addresses bounced last
time I used them.)
On Wed, Mar 02, 2022 at 08:04:45PM +0100, Krzysztof Kozlowski wrote:
> On 14/02/2022 22:21, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > Changes since v1:
> > 1. Add tags.
> > 2. Adjust subject (Uwe).
> >
>
> Hi Thierry, Uwe and Lee,
>
> Any comments here? Rob acked all these, so these are clear to go via PWM
> tree.
They are fine from my side:
Acked-by: Uwe Kleine-K?nig <[email protected]>
It's Thierry who is reponsible to pick these up and it seems he marked
the series as accepted:
https://patchwork.ozlabs.org/project/linux-pwm/list/?series=286150&state=*
So I would expect that it turns up in next after Thierry is done with
his testing.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |