2022-02-21 07:34:16

by tangmeng

Subject: [PATCH] kernel/debug: remove unnecessary CONFIG options

In kernel/Makefile has:
obj-$(CONFIG_KGDB) += debug/

so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=',
delete it from kernel/debug/Makefile.

Signed-off-by: tangmeng <[email protected]>
---
kernel/debug/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/debug/Makefile b/kernel/debug/Makefile
index 332ee6c6ec2c..9c49ff7c75f4 100644
--- a/kernel/debug/Makefile
+++ b/kernel/debug/Makefile
@@ -3,5 +3,5 @@
# Makefile for the linux kernel debugger
#

-obj-$(CONFIG_KGDB) += debug_core.o gdbstub.o
+obj-y += debug_core.o gdbstub.o
obj-$(CONFIG_KGDB_KDB) += kdb/
--
2.20.1

2022-02-23 14:34:00

by Doug Anderson

Subject: Re: [PATCH] kernel/debug: remove unnecessary CONFIG options

Hi,

On Sun, Feb 20, 2022 at 10:20 PM tangmeng <[email protected]> wrote:
>
> In kernel/Makefile has:
> obj-$(CONFIG_KGDB) += debug/
>
> so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=',
> delete it from kernel/debug/Makefile.
>
> Signed-off-by: tangmeng <[email protected]>
> ---
> kernel/debug/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Seems fine to me, with the nit that your Signed-off-by is supposed to
have your "real name", not your username. See
`Documentation/process/submitting-patches.rst`. Some maintainers will
let this slide, but if you're going to submit a patch fixing a nitty
issue then it seems fair to get called out on nits. ;-)

-Doug