2022-02-23 15:17:32

by Ivan Bornyakov

Subject: Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error

On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/bus/imx-weim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..2ea0a51f79f6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>
> pdev = of_find_device_by_node(rd->dn);
> if (!pdev) {
> - dev_err(&pdev->dev,
> - "Could not find platform device for '%pOF'\n",
> + pr_err("Could not find platform device for '%pOF'\n",
> rd->dn);
>
> ret = notifier_from_errno(-EINVAL);
> --
> 2.35.1
>

Acked-by: Ivan Bornyakov <[email protected]>

2022-04-06 16:32:56

by Shawn Guo

Subject: Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error

On Wed, Feb 23, 2022 at 09:58:15AM +0300, Ivan Bornyakov wrote:
> On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> > Fix following coccicheck warning:
> > ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
> >
> > Signed-off-by: Wan Jiabing <[email protected]>

Applied, thanks.