2022-02-24 01:51:33

by Aparna M

Subject: [PATCH v2] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0

From: Kishon Vijay Abraham I <[email protected]>

WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
This will enable the WiFi functionaliy on the board.

Signed-off-by: Kishon Vijay Abraham I <[email protected]>
Signed-off-by: Vignesh Raghavendra <[email protected]>
Signed-off-by: Nikhil Devshatwar <[email protected]>
Signed-off-by: Aparna M <[email protected]>
---

v1 -> v2: Update commit message with "From:" details

arch/arm64/boot/dts/ti/k3-am642-sk.dts | 62 ++++++++++++++++++++++++++
1 file changed, 62 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index 6b04745147be..1178bb982f05 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -125,6 +125,31 @@
vin-supply = <&vcc_3v3_sys>;
gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
};
+
+ com8_ls_en: fixed-regulator-com8 {
+ compatible = "regulator-fixed";
+ regulator-name = "com8_ls_en";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ pinctrl-0 = <&main_com8_ls_en_pins_default>;
+ pinctrl-names = "default";
+ gpio = <&main_gpio0 62 GPIO_ACTIVE_LOW>;
+ };
+
+ wlan_en: fixed-regulator-wlan {
+ /* output of SN74AVC4T245RSVR */
+ compatible = "regulator-fixed";
+ regulator-name = "wlan_en";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ enable-active-high;
+ pinctrl-0 = <&main_wlan_en_pins_default>;
+ pinctrl-names = "default";
+ vin-supply = <&com8_ls_en>;
+ gpio = <&main_gpio0 48 GPIO_ACTIVE_HIGH>;
+ };
};

&main_pmx0 {
@@ -216,6 +241,23 @@
AM64X_IOPAD(0x0270, PIN_INPUT, 0) /* (D18) ECAP0_IN_APWM_OUT */
>;
};
+ main_wlan_en_pins_default: main-wlan-en-pins-default {
+ pinctrl-single,pins = <
+ AM64X_IOPAD(0x00c4, PIN_OUTPUT_PULLUP, 7) /* (V8) GPIO0_48 */
+ >;
+ };
+
+ main_com8_ls_en_pins_default: main-com8-ls-en-pins-default {
+ pinctrl-single,pins = <
+ AM64X_IOPAD(0x00fc, PIN_OUTPUT, 7) /* (U7) PRG1_PRU0_GPO17.GPIO0_62 */
+ >;
+ };
+
+ main_wlan_pins_default: main-wlan-pins-default {
+ pinctrl-single,pins = <
+ AM64X_IOPAD(0x00bc, PIN_INPUT, 7) /* (U8) GPIO0_46 */
+ >;
+ };
};

&mcu_uart0 {
@@ -293,6 +335,26 @@
status = "reserved";
};

+&sdhci0 {
+ vmmc-supply = <&wlan_en>;
+ bus-width = <4>;
+ non-removable;
+ cap-power-off-card;
+ keep-power-in-suspend;
+ ti,driver-strength-ohm = <50>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+ wlcore: wlcore@2 {
+ compatible = "ti,wl1837";
+ reg = <2>;
+ pinctrl-0 = <&main_wlan_pins_default>;
+ pinctrl-names = "default";
+ interrupt-parent = <&main_gpio0>;
+ interrupts = <46 IRQ_TYPE_EDGE_FALLING>;
+ };
+};
+
&sdhci1 {
/* SD/MMC */
vmmc-supply = <&vdd_mmc1>;
--
2.17.1

2022-02-25 12:20:02

by Vignesh Raghavendra

Subject: Re: [PATCH v2] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to SDHCI0

Hi

On 23/02/22 9:27 pm, Aparna M wrote:
> From: Kishon Vijay Abraham I <[email protected]>
>
> WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
> This will enable the WiFi functionaliy on the board.
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> Signed-off-by: Vignesh Raghavendra <[email protected]>
> Signed-off-by: Nikhil Devshatwar <[email protected]>
> Signed-off-by: Aparna M <[email protected]>
> ---
>
> v1 -> v2: Update commit message with "From:" details
>
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 62 ++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 6b04745147be..1178bb982f05 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -125,6 +125,31 @@
> vin-supply = <&vcc_3v3_sys>;
> gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
> };
> +
> + com8_ls_en: fixed-regulator-com8 {

Please use generic node names as per DT spec [1]

Something like:
com8_ls_en: regulator-1 {
...
};



> + compatible = "regulator-fixed";
> + regulator-name = "com8_ls_en";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + pinctrl-0 = <&main_com8_ls_en_pins_default>;
> + pinctrl-names = "default";
> + gpio = <&main_gpio0 62 GPIO_ACTIVE_LOW>;
> + };
> +
> + wlan_en: fixed-regulator-wlan {

same as above

> + /* output of SN74AVC4T245RSVR */
> + compatible = "regulator-fixed";
> + regulator-name = "wlan_en";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + enable-active-high;
> + pinctrl-0 = <&main_wlan_en_pins_default>;
> + pinctrl-names = "default";
> + vin-supply = <&com8_ls_en>;
> + gpio = <&main_gpio0 48 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &main_pmx0 {

[...]

[1]
https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.4-rc1


Regards
Vignesh