Add support for the IST3038C touchscreen IC from Imagis, based on
downstream driver. The driver supports multi-touch (10 touch points)
The IST3038C IC supports touch keys, but the support isn't added
because the touch screen used for testing doesn't utilize touch keys.
Looking at the downstream driver, it is possible to add support
for other Imagis ICs of IST30**C series.
Signed-off-by: Markuss Broks <[email protected]>
---
MAINTAINERS | 6 +
drivers/input/touchscreen/Kconfig | 10 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/imagis.c | 347 +++++++++++++++++++++++++++++
4 files changed, 364 insertions(+)
create mode 100644 drivers/input/touchscreen/imagis.c
diff --git a/MAINTAINERS b/MAINTAINERS
index a899828a8d4e..3b99c60e9f4b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9411,6 +9411,12 @@ M: Stanislaw Gruszka <[email protected]>
S: Maintained
F: drivers/usb/atm/ueagle-atm.c
+IMAGIS TOUCHSCREEN DRIVER
+M: Markuss Broks <[email protected]>
+S: Maintained
+F: Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
+F: drivers/input/touchscreen/imagis.c
+
IMGTEC ASCII LCD DRIVER
M: Paul Burton <[email protected]>
S: Maintained
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 2f6adfb7b938..f1414f0ad7af 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -638,6 +638,16 @@ config TOUCHSCREEN_MTOUCH
To compile this driver as a module, choose M here: the
module will be called mtouch.
+config TOUCHSCREEN_IMAGIS
+ tristate "Imagis touchscreen support"
+ depends on I2C
+ help
+ Say Y here if you have an Imagis IST30xxC touchscreen.
+ If unsure, say N.
+
+ To compile this driver as a module, choose M here: the
+ module will be called imagis.
+
config TOUCHSCREEN_IMX6UL_TSC
tristate "Freescale i.MX6UL touchscreen controller"
depends on ((OF && GPIOLIB) || COMPILE_TEST) && HAS_IOMEM
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index 39a8127cf6a5..557f84fd2075 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -49,6 +49,7 @@ obj-$(CONFIG_TOUCHSCREEN_GOODIX) += goodix_ts.o
obj-$(CONFIG_TOUCHSCREEN_HIDEEP) += hideep.o
obj-$(CONFIG_TOUCHSCREEN_ILI210X) += ili210x.o
obj-$(CONFIG_TOUCHSCREEN_ILITEK) += ilitek_ts_i2c.o
+obj-$(CONFIG_TOUCHSCREEN_IMAGIS) += imagis.o
obj-$(CONFIG_TOUCHSCREEN_IMX6UL_TSC) += imx6ul_tsc.o
obj-$(CONFIG_TOUCHSCREEN_INEXIO) += inexio.o
obj-$(CONFIG_TOUCHSCREEN_IPROC) += bcm_iproc_tsc.o
diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c
new file mode 100644
index 000000000000..92c6a7e0a15e
--- /dev/null
+++ b/drivers/input/touchscreen/imagis.c
@@ -0,0 +1,347 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/bits.h>
+#include <linux/delay.h>
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/input/mt.h>
+#include <linux/input/touchscreen.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/property.h>
+#include <linux/regulator/consumer.h>
+
+#define IST3038C_HIB_ACCESS (0x800B << 16)
+#define IST3038C_DIRECT_ACCESS BIT(31)
+#define IST3038C_REG_CHIPID 0x40001000
+#define IST3038C_REG_HIB_BASE 0x30000100
+#define IST3038C_REG_TOUCH_STATUS (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS)
+#define IST3038C_REG_TOUCH_COORD (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x8)
+#define IST3038C_REG_INTR_MESSAGE (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x4)
+#define IST3038C_WHOAMI 0x38c
+#define IST3038C_CHIP_ON_DELAY_MS 60
+#define IST3038C_I2C_RETRY_COUNT 3
+#define IST3038C_MAX_SUPPORTED_FINGER_NUM 10
+#define IST3038C_X_MASK GENMASK(23, 12)
+#define IST3038C_X_SHIFT 12
+#define IST3038C_Y_MASK GENMASK(11, 0)
+#define IST3038C_AREA_MASK GENMASK(27, 24)
+#define IST3038C_AREA_SHIFT 24
+#define IST3038C_FINGER_COUNT_MASK GENMASK(15, 12)
+#define IST3038C_FINGER_COUNT_SHIFT 12
+#define IST3038C_FINGER_STATUS_MASK GENMASK(9, 0)
+
+struct imagis_ts {
+ struct i2c_client *client;
+ struct input_dev *input_dev;
+ struct touchscreen_properties prop;
+ struct regulator_bulk_data supplies[2];
+};
+
+static int imagis_i2c_read_reg(struct imagis_ts *ts,
+ unsigned int reg, unsigned int *buffer)
+{
+ __be32 reg_be = cpu_to_be32(reg);
+ struct i2c_msg msg[] = {
+ {
+ .addr = ts->client->addr,
+ .flags = 0,
+ .buf = (unsigned char *)®_be,
+ .len = sizeof(reg_be),
+ }, {
+ .addr = ts->client->addr,
+ .flags = I2C_M_RD,
+ .buf = (unsigned char *)buffer,
+ .len = sizeof(reg_be),
+ },
+ };
+ int ret, error;
+ int retry = IST3038C_I2C_RETRY_COUNT;
+
+ /* Retry in case the controller fails to respond */
+ do {
+ ret = i2c_transfer(ts->client->adapter, msg, ARRAY_SIZE(msg));
+ if (ret == ARRAY_SIZE(msg)) {
+ *buffer = be32_to_cpu(*buffer);
+ return 0;
+ }
+
+ error = ret < 0 ? ret : -EIO;
+ dev_err(&ts->client->dev,
+ "%s - i2c_transfer failed: %d (%d)\n",
+ __func__, error, ret);
+ } while (--retry);
+
+ return error;
+}
+
+static irqreturn_t imagis_interrupt(int irq, void *dev_id)
+{
+ struct imagis_ts *ts = dev_id;
+ unsigned int finger_status, intr_message;
+ int error, i, finger_count, finger_pressed;
+
+ error = imagis_i2c_read_reg(ts, IST3038C_REG_INTR_MESSAGE, &intr_message);
+ if (error) {
+ dev_err(&ts->client->dev, "failed to read the interrupt message\n");
+ return IRQ_HANDLED;
+ }
+
+ finger_count = (intr_message & IST3038C_FINGER_COUNT_MASK) >> IST3038C_FINGER_COUNT_SHIFT;
+ finger_pressed = intr_message & IST3038C_FINGER_STATUS_MASK;
+ if (finger_count > IST3038C_MAX_SUPPORTED_FINGER_NUM) {
+ dev_err(&ts->client->dev, "finger count is more than maximum supported\n");
+ return IRQ_HANDLED;
+ }
+
+ for (i = 0; i < finger_count; i++) {
+ error = imagis_i2c_read_reg(ts, IST3038C_REG_TOUCH_COORD + (i * 4), &finger_status);
+ if (error) {
+ dev_err(&ts->client->dev, "failed to read coordinates for finger %d\n", i);
+ return IRQ_HANDLED;
+ }
+ input_mt_slot(ts->input_dev, i);
+ input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER,
+ finger_pressed & BIT(i));
+ touchscreen_report_pos(ts->input_dev, &ts->prop,
+ (finger_status & IST3038C_X_MASK) >> IST3038C_X_SHIFT,
+ finger_status & IST3038C_Y_MASK, 1);
+ input_report_abs(ts->input_dev, ABS_MT_TOUCH_MAJOR,
+ (finger_status & IST3038C_AREA_MASK) >> IST3038C_AREA_SHIFT);
+ }
+ input_mt_sync_frame(ts->input_dev);
+ input_sync(ts->input_dev);
+
+ return IRQ_HANDLED;
+}
+
+static int imagis_power_off(struct imagis_ts *ts)
+{
+ int error;
+
+ error = regulator_bulk_disable(ARRAY_SIZE(ts->supplies),
+ ts->supplies);
+ if (error)
+ dev_err(&ts->client->dev,
+ "Failed to disable regulators: %d\n", error);
+ return error;
+}
+
+static int imagis_power_on(struct imagis_ts *ts)
+{
+ int error;
+
+ error = regulator_bulk_enable(ARRAY_SIZE(ts->supplies),
+ ts->supplies);
+ if (error)
+ dev_err(&ts->client->dev,
+ "Failed to enable regulators: %d\n", error);
+ return error;
+}
+
+static int imagis_start(struct imagis_ts *ts)
+{
+ int error;
+
+ error = imagis_power_on(ts);
+ if (error)
+ return error;
+
+ msleep(IST3038C_CHIP_ON_DELAY_MS);
+
+ enable_irq(ts->client->irq);
+ return error;
+}
+
+static int imagis_stop(struct imagis_ts *ts)
+{
+ disable_irq(ts->client->irq);
+
+ return imagis_power_off(ts);
+}
+
+static int imagis_input_open(struct input_dev *dev)
+{
+ struct imagis_ts *ts = input_get_drvdata(dev);
+
+ return imagis_start(ts);
+}
+
+static void imagis_input_close(struct input_dev *dev)
+{
+ struct imagis_ts *ts = input_get_drvdata(dev);
+
+ imagis_stop(ts);
+}
+
+static int imagis_init_input_dev(struct imagis_ts *ts)
+{
+ struct input_dev *input_dev;
+ int error;
+
+ input_dev = devm_input_allocate_device(&ts->client->dev);
+ if (!input_dev)
+ return -ENOMEM;
+
+ ts->input_dev = input_dev;
+
+ input_dev->name = "Imagis capacitive touchscreen";
+ input_dev->phys = "input/ts";
+ input_dev->id.bustype = BUS_I2C;
+ input_dev->open = imagis_input_open;
+ input_dev->close = imagis_input_close;
+
+ input_set_drvdata(input_dev, ts);
+
+ input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_X);
+ input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_Y);
+ input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
+
+ touchscreen_parse_properties(input_dev, true, &ts->prop);
+ if (!ts->prop.max_x || !ts->prop.max_y) {
+ dev_err(&ts->client->dev,
+ "Touchscreen-size-x and/or touchscreen-size-y not set in dts\n");
+ return -EINVAL;
+ }
+
+ error = input_mt_init_slots(input_dev, IST3038C_MAX_SUPPORTED_FINGER_NUM,
+ INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
+ if (error) {
+ dev_err(&ts->client->dev,
+ "Failed to initialize MT slots: %d", error);
+ return error;
+ }
+
+ error = input_register_device(input_dev);
+ if (error) {
+ dev_err(&ts->client->dev,
+ "Failed to register input device: %d", error);
+ return error;
+ }
+
+ return 0;
+}
+
+static int imagis_init_regulators(struct imagis_ts *ts)
+{
+ struct i2c_client *client = ts->client;
+ int error = 0;
+
+ ts->supplies[0].supply = "vdd";
+ ts->supplies[1].supply = "vddio";
+ error = devm_regulator_bulk_get(&client->dev,
+ ARRAY_SIZE(ts->supplies),
+ ts->supplies);
+
+ return error;
+}
+
+static int imagis_probe(struct i2c_client *i2c)
+{
+ struct device *dev;
+ struct imagis_ts *ts;
+ int chip_id, ret, error;
+
+ dev = &i2c->dev;
+
+ ts = devm_kzalloc(dev, sizeof(*ts), GFP_KERNEL);
+ if (!ts)
+ return -ENOMEM;
+
+ ts->client = i2c;
+
+ error = imagis_init_regulators(ts);
+ if (error)
+ return dev_err_probe(dev, error, "regulator init error: %d\n", error);
+
+ error = imagis_power_on(ts);
+ if (error)
+ return dev_err_probe(dev, error, "failed to enable regulators: %d\n", error);
+
+ msleep(IST3038C_CHIP_ON_DELAY_MS);
+
+ ret = imagis_i2c_read_reg(ts, IST3038C_REG_CHIPID | IST3038C_DIRECT_ACCESS, &chip_id);
+ if (ret) {
+ imagis_power_off(ts);
+ return dev_err_probe(dev, error, "chip ID read failure: %d\n", ret);
+ }
+
+ if (chip_id != IST3038C_WHOAMI) {
+ imagis_power_off(ts);
+ return dev_err_probe(dev, -EINVAL, "unknown chip ID: 0x%x\n", chip_id);
+ }
+
+ error = devm_request_threaded_irq(dev, i2c->irq,
+ NULL, imagis_interrupt,
+ IRQF_ONESHOT | IRQF_NO_AUTOEN,
+ "imagis-touchscreen", ts);
+ if (error) {
+ imagis_power_off(ts);
+ return dev_err_probe(dev, error, "IRQ allocation failure: %d\n", error);
+ }
+
+ error = imagis_init_input_dev(ts);
+ if (error) {
+ imagis_power_off(ts);
+ return dev_err_probe(dev, error, "input subsystem init error: %d\n", error);
+ }
+
+ return 0;
+}
+
+static int __maybe_unused imagis_suspend(struct device *dev)
+{
+ struct i2c_client *client = to_i2c_client(dev);
+ struct imagis_ts *ts = i2c_get_clientdata(client);
+ int ret;
+
+ mutex_lock(&ts->input_dev->mutex);
+
+ if (input_device_enabled(ts->input_dev))
+ ret = imagis_stop(ts);
+
+ mutex_unlock(&ts->input_dev->mutex);
+
+ return ret;
+}
+
+static int __maybe_unused imagis_resume(struct device *dev)
+{
+ struct i2c_client *client = to_i2c_client(dev);
+ struct imagis_ts *ts = i2c_get_clientdata(client);
+ int ret;
+
+ mutex_lock(&ts->input_dev->mutex);
+
+ if (input_device_enabled(ts->input_dev))
+ ret = imagis_start(ts);
+
+ mutex_unlock(&ts->input_dev->mutex);
+
+ return ret;
+}
+
+static SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
+
+#ifdef CONFIG_OF
+static const struct of_device_id imagis_of_match[] = {
+ { .compatible = "imagis,ist3038c", },
+ { },
+};
+MODULE_DEVICE_TABLE(of, imagis_of_match);
+#endif
+
+static struct i2c_driver imagis_ts_driver = {
+ .driver = {
+ .name = "imagis-touchscreen",
+ .pm = &imagis_pm_ops,
+ .of_match_table = of_match_ptr(imagis_of_match),
+ },
+ .probe_new = imagis_probe,
+};
+
+module_i2c_driver(imagis_ts_driver);
+
+MODULE_DESCRIPTION("Imagis IST3038C Touchscreen Driver");
+MODULE_AUTHOR("Markuss Broks <[email protected]>");
+MODULE_LICENSE("GPL");
--
2.35.0
Hi Markuss,
I love your patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on linux/master robh/for-next linus/master v5.17-rc5 next-20220222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220223/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bc77ee5e0d7309edca7d65925c6afa05334b0b01
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
git checkout bc77ee5e0d7309edca7d65925c6afa05334b0b01
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/input/touchscreen/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> drivers/input/touchscreen/imagis.c:300:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:305:9: note: uninitialized use occurs here
return ret;
^~~
drivers/input/touchscreen/imagis.c:300:2: note: remove the 'if' if its condition is always true
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:296:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
drivers/input/touchscreen/imagis.c:316:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:321:9: note: uninitialized use occurs here
return ret;
^~~
drivers/input/touchscreen/imagis.c:316:2: note: remove the 'if' if its condition is always true
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:312:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
2 warnings generated.
vim +300 drivers/input/touchscreen/imagis.c
291
292 static int __maybe_unused imagis_suspend(struct device *dev)
293 {
294 struct i2c_client *client = to_i2c_client(dev);
295 struct imagis_ts *ts = i2c_get_clientdata(client);
296 int ret;
297
298 mutex_lock(&ts->input_dev->mutex);
299
> 300 if (input_device_enabled(ts->input_dev))
301 ret = imagis_stop(ts);
302
303 mutex_unlock(&ts->input_dev->mutex);
304
305 return ret;
306 }
307
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Hi Markuss,
I love your patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on linux/master robh/for-next linus/master v5.17-rc5 next-20220222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: arm-randconfig-s031-20220223 (https://download.01.org/0day-ci/archive/20220223/[email protected]/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/bc77ee5e0d7309edca7d65925c6afa05334b0b01
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
git checkout bc77ee5e0d7309edca7d65925c6afa05334b0b01
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash drivers/input/touchscreen/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
sparse warnings: (new ones prefixed by >>)
>> drivers/input/touchscreen/imagis.c:65:35: sparse: sparse: cast to restricted __be32
vim +65 drivers/input/touchscreen/imagis.c
40
41 static int imagis_i2c_read_reg(struct imagis_ts *ts,
42 unsigned int reg, unsigned int *buffer)
43 {
44 __be32 reg_be = cpu_to_be32(reg);
45 struct i2c_msg msg[] = {
46 {
47 .addr = ts->client->addr,
48 .flags = 0,
49 .buf = (unsigned char *)®_be,
50 .len = sizeof(reg_be),
51 }, {
52 .addr = ts->client->addr,
53 .flags = I2C_M_RD,
54 .buf = (unsigned char *)buffer,
55 .len = sizeof(reg_be),
56 },
57 };
58 int ret, error;
59 int retry = IST3038C_I2C_RETRY_COUNT;
60
61 /* Retry in case the controller fails to respond */
62 do {
63 ret = i2c_transfer(ts->client->adapter, msg, ARRAY_SIZE(msg));
64 if (ret == ARRAY_SIZE(msg)) {
> 65 *buffer = be32_to_cpu(*buffer);
66 return 0;
67 }
68
69 error = ret < 0 ? ret : -EIO;
70 dev_err(&ts->client->dev,
71 "%s - i2c_transfer failed: %d (%d)\n",
72 __func__, error, ret);
73 } while (--retry);
74
75 return error;
76 }
77
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Hi Markuss,
url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: microblaze-randconfig-m031-20220224 (https://download.01.org/0day-ci/archive/20220225/[email protected]/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
smatch warnings:
drivers/input/touchscreen/imagis.c:305 imagis_suspend() error: uninitialized symbol 'ret'.
drivers/input/touchscreen/imagis.c:321 imagis_resume() error: uninitialized symbol 'ret'.
vim +/ret +305 drivers/input/touchscreen/imagis.c
bc77ee5e0d7309 Markuss Broks 2022-02-22 292 static int __maybe_unused imagis_suspend(struct device *dev)
bc77ee5e0d7309 Markuss Broks 2022-02-22 293 {
bc77ee5e0d7309 Markuss Broks 2022-02-22 294 struct i2c_client *client = to_i2c_client(dev);
bc77ee5e0d7309 Markuss Broks 2022-02-22 295 struct imagis_ts *ts = i2c_get_clientdata(client);
bc77ee5e0d7309 Markuss Broks 2022-02-22 296 int ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22 297
bc77ee5e0d7309 Markuss Broks 2022-02-22 298 mutex_lock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22 299
bc77ee5e0d7309 Markuss Broks 2022-02-22 300 if (input_device_enabled(ts->input_dev))
bc77ee5e0d7309 Markuss Broks 2022-02-22 301 ret = imagis_stop(ts);
"ret" not initialized on else path.
bc77ee5e0d7309 Markuss Broks 2022-02-22 302
bc77ee5e0d7309 Markuss Broks 2022-02-22 303 mutex_unlock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22 304
bc77ee5e0d7309 Markuss Broks 2022-02-22 @305 return ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22 306 }
bc77ee5e0d7309 Markuss Broks 2022-02-22 307
bc77ee5e0d7309 Markuss Broks 2022-02-22 308 static int __maybe_unused imagis_resume(struct device *dev)
bc77ee5e0d7309 Markuss Broks 2022-02-22 309 {
bc77ee5e0d7309 Markuss Broks 2022-02-22 310 struct i2c_client *client = to_i2c_client(dev);
bc77ee5e0d7309 Markuss Broks 2022-02-22 311 struct imagis_ts *ts = i2c_get_clientdata(client);
bc77ee5e0d7309 Markuss Broks 2022-02-22 312 int ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22 313
bc77ee5e0d7309 Markuss Broks 2022-02-22 314 mutex_lock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22 315
bc77ee5e0d7309 Markuss Broks 2022-02-22 316 if (input_device_enabled(ts->input_dev))
bc77ee5e0d7309 Markuss Broks 2022-02-22 317 ret = imagis_start(ts);
same.
bc77ee5e0d7309 Markuss Broks 2022-02-22 318
bc77ee5e0d7309 Markuss Broks 2022-02-22 319 mutex_unlock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22 320
bc77ee5e0d7309 Markuss Broks 2022-02-22 @321 return ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22 322 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]