2022-02-26 01:50:03

by Jia-Ju Bai

Subject: [PATCH] atm: firestream: check the return value of ioremap() in fs_init()

The function ioremap() in fs_init() can fail, so its return value should
be checked.

Reported-by: TOTE Robot <[email protected]>
Signed-off-by: Jia-Ju Bai <[email protected]>
---
drivers/atm/firestream.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 3bc3c314a467..4f67404fe64c 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -1676,6 +1676,8 @@ static int fs_init(struct fs_dev *dev)
dev->hw_base = pci_resource_start(pci_dev, 0);

dev->base = ioremap(dev->hw_base, 0x1000);
+ if (!dev->base)
+ return 1;

reset_chip (dev);

--
2.17.1

2022-02-28 17:51:18

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] atm: firestream: check the return value of ioremap() in fs_init()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Fri, 25 Feb 2022 04:52:30 -0800 you wrote:
> The function ioremap() in fs_init() can fail, so its return value should
> be checked.
>
> Reported-by: TOTE Robot <[email protected]>
> Signed-off-by: Jia-Ju Bai <[email protected]>
> ---
> drivers/atm/firestream.c | 2 ++
> 1 file changed, 2 insertions(+)

Here is the summary with links:
- atm: firestream: check the return value of ioremap() in fs_init()
https://git.kernel.org/netdev/net/c/d4e26aaea7f8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html